Paul Wise authored 11 months ago and Antoine Lambert committed 11 months ago

Uses a hidden disabled selected option with an empty value to do this.

Prevents accidentally submitting forges as the first forge type,
which is currently bitbucket, which is rarely used on the web.

The AFN submission API already rejects an empty forge type,
giving a reasonably good error to the end-user.

Using a postcss plugin now results in a lot of displayed warnings so
prefer to use a dedicated webpack plugin to trigger CSS linting.

Antoine Lambert authored 1 year ago and Antoine Lambert committed 1 year ago

Restore previous behavior and select by default the latest visit of
an origin regardless of its type.

This reverts commit 9c2e3a12.

Antoine Lambert authored 1 year ago and Antoine Lambert committed 1 year ago

Align returned data with other endpoints related to origins by adding
visit types info in order to fix errors in the search Web UI.

Antoine Lambert authored 1 year ago and Antoine Lambert committed 1 year ago

This code was used at the time to get extra info (notably stack trace) about
a save code now task but this no longer works since a while and it is redundant
with sentry so better removing it.

Those are no longer rendered after previous commits preventing XSS
so prefer to simply display URLs instead.

This avoids an XSS avenue within errors

swh-storage revision_log() method is expected to return Revision objects
in a near future, so make sure we handle this properly.

It seems we depend on v3 now (v2 generates an AttributeError for
webpack_loader.loaders).

This matches what swh-search returns and expects. This could make
test_lookup_origin() (in test_archive.py) fail when the bad luck (?) made
hypothesis generate a test set where swh-search's in-memory backend
tries to merge the visit_types with an existing one (thus trying to add
a pair set objects).

Adapt the definition of OriginInfo (more or less the local version of
swh-search's OriginDict) accordingly.

Since the release of pytest 8.1, some pytest options are no longer
needed and editable install can be used when running tests using tox.

Antoine Lambert authored 1 year ago and Antoine Lambert committed 1 year ago

When searching for origins with the Web UI, if the search pattern is equal
to the URL of an archived origin then user gets automatically redirected to
the interface for browsing it.

Previously the visit type was not taken into account prior performing the
redirection so ensure to redirect only if the origin has a visit type
that matches the selected one.

Instead of writing a dummy webpack-stats.json file into the static folder
of swh-web when pytest is configured, prefer to autouse a session scoped
fixture mocking the return value of WebpackLoader.load_assets.

Use new option consider_namespace_packages to fix tests execution
with latest pytest release.

Some Jupyter notebooks rendered by the webapp might require the use of
mathjax extensions that were not available in the static assets.

So ensure those extensions are available and can be lazily loaded when
required.

Those are not of interest and generate a lot of noises in swh-web dashboard
from Sentry Web UI.

To support secret key rotation, allow setting SECRET_KEY_FALLBACKS in
the swh-web yaml config.

Introduce support of SECRET_KEY_FALLBACKS for inbound email validation.

After the migration to Django 4, the signature algorithm for signed
addresses was upgraded to sha256. However, sha1-based addresses still
exist in the wild, so we need to keep supporting them.

The current setup wouldn't allow Bcc's, bounces or aliases, throwing a
400 error.

It seems it is possible for the _savable_visit_types() helper function
to be called with an empty 'visit_types' (case found in docker tests).

Prevent an IndexError.

Datatables 2.0 can send a request to restore default ordering based
on data index but it was not properly handled by the related views.

Versions of extids related to nix/guix were bumped to 1 as some issues
were detected in production after the first batch of related loadings.

Related to swh/infra/sysadm-environment#5222.

It enables to have a fixed header when browsing a table with a large
amount of entries per page.

When increasing the number of entries per page to display, it enables
to scroll the page instead of scrolling a table of fixed height.

When no visit type for an origin is explicitly provided as query parameter,
ensure a full VCS visit type (git, svn or hg) is selected by default when
an origin has multiple visit types.

Related to #4786.

Previously, the checksums for each file was stored in the cache but those
are not exploited by the browse code so we can safely remove that dict
to optimize the cached entry size and avoid reaching memcached size limit
for large directories in production.

When visit type filtering is not enabled in the search options, ensure
to display all visit types for an origin in search results.

Related to #4786.