The filesystem of a revision is browsable from the associated view
but the display of the languages selection dropdown was missing when
browsing a content.

Ensure languages selection dropdown is displayed for content whose
mime type starts with application/ if the content encoding is not
binary, for instance application/json.

The forcing of visit type introduced in 937a9609 should only be
done when no snapshot related info have been passed as parameters
to the get_snapshot_context function.

Scheduler temporary backend has been removed in favor of a more
efficient memory backend.

Antoine Lambert authored 1 year ago and Antoine Lambert committed 4 months ago

When no visit type for an origin is explicitly provided as query parameter,
ensure a full VCS visit type (git, svn or hg) is selected by default when
an origin has multiple visit types.

Related to #4786.

Previously, the length query parameter value sent to datatables list
views implemented backend side was not restrained to a maximum value,
making a potential DoS vector attack.

Set that maximum value to 1000 which is the max page length offered
by datatables Web UIs in swh-web.

This maximum value can also be modified through configuration.

Fixes #4820.

When the path query parameter targets a content in the root directory
and has a leading slash, a 404 error was previously raised so ensure
to handle that special case.

When browsing an archived object without any context (a plain revision for
instance), the javascript variable swhid_with_context_url is null so the
code computing parameter for the Web API citation endpoint was raising an
exception.

Spotted thanks to the cypress tests execution on Jenkins.

Django unescapes percent encoded query parameters when parsing them so we
need to ensure the % character a SWHID can contain is escaped to avoid
parsing an invalid SWHID.

The minify-html tool use to minify HTML through a django middleware
strips the type="submit" attribute from button elements so use ids
instead to get such elements in cypress tests.

Use HTML minification as in production to catch possible issues.

Our custom HtmlMinifyMiddleware was using htmlmin package under the hood
but it is no longer maintained and does not support Python 3.13.

Prefer to use the django-minify-html package instead which is maintained
and offers better performances as it is using an HTML minifier written in
rust in its implementation.

Canonicalise only forge URLs identified by pabs and not the whole
set in database.

Really fixes swh/infra/sysadm-environment#5504.

Fixes swh/infra/sysadm-environment#5504.

Some tests were using canonical Bitbucket/Gitea/GitLab domains that
should be blocked from being submitted to Add Forge Now.

Other tests were using domains that have been parked.

Otherwise it could match URLs containing GitHub in the path/search/anchor,
or with domains similar to GitHub ones but without the periods.

Antoine Lambert authored 4 months ago and Paul Wise committed 4 months ago

Check AFN creation form is rejecting new types of invalid forge URLs
according to newly introduced forge URL validation rules.

Antoine Lambert authored 4 months ago and Paul Wise committed 4 months ago

As URL input in AFN form is validated at each typed character,
the javascript URL constructor can raise an exception so it
needs to be handled.

Check that it is not a URL to a GitHub repo or website,
is a canonical URL with a trailing forward slash and
is a base URL rather than a repository or other URL.

Fixes: #4794
Fixes: #4792

Previously, functions from the archive module to query origin visit info
were returning the latest visit status date instead of the visit date.

This could lead to wrong returned visit when searching a visit by date
through links offered by the webapp as the wrong visit date was used.

Previously, the page size was not taken into account and the default limit
value of 1000 was used when calling get_listed_origins from scheduler API
leading to incomplete API responses.

Fixes #4819.

Dates returned by origin_visit_stats_get from scheduler API are
converted to local timezone which can make tests failed if local
timezone is different from UTC.

This should have been committed in f571c557 but the change was lost
somehow. Citations tab was always displayed while it must be only
when a citation metadata file is available in the browsing context.

Antoine Lambert authored 5 months ago and Antoine Lambert committed 4 months ago

Users having the swh.ambassador permission will have the citations UI
displayed when logged in.

Hypothesis may generate the same URL twice (or more) in the same test
session, in which case the given URL would already be in
archive._origin_info() cache, defeating the test.

So clear django cache completely before running this test.

Antoine Lambert authored 5 months ago and Antoine Lambert committed 4 months ago

Do not show Citations tab by default and activate its display only when
a software citation can be generated from the browse context.

Related to #4815.

Antoine Lambert authored 5 months ago and Antoine Lambert committed 4 months ago

When a parsing error occurs when attempting to generate a citation,
store error message in Citation dictionary and return an error response
enriched with SWHID of citation metadata source file.

It enables to get feedback to users about errors in the citations Web UI
while offering link to the bogus metadata file.

Antoine Lambert authored 5 months ago and Antoine Lambert committed 4 months ago

Some deposit XML metadata are provided non formatted on a single line
so ensure to prettify them before display in the deposits admin Web UI.

Using a CharField with at most 200 characters was too restrictive
as some URLs can exceed that length so bump the maximum number of
characters to 4096.

Resolves #4818.

Using a CharField with at most 200 characters was too restrictive
as some URLs can exceed that length so bump the maximum number of
characters to 4096.

Drop the mention of the request since it can cause admin concerns.

Switch from the "forge" terminology to "code" and site" since
"forge" is outdated terminology since the advent of GitHub,
which did not keep up the tradition of old code forges.

Mention that the archiving will be regular too.