Paul Wise authored 1 month ago and Antoine Lambert committed 1 month ago

These just result in a rejection from the archival moderation team.

The GitLab API sets the appropriate CORS headers for this to work.

Co-authored-by: Antoine Lambert <anlambert@softwareheritage.org>

It allows to simplify the static files configuration with django
and to remove the use of the deprecated data_files option from
setuptools.

When searching for an origin URL, the search interface redirects
to its browse interface if the origin URL exists in SWH database.

Nevertheless, it the origin could not be archived, the redirection
was still done leading to a 404 error so ensure to check the origin
has a snapshot before redirecting.

Fixes #4828.

The bootstrap admin theme we are using (AdminLTE) recently added support for
bootstrap 5.x in its 4.0 release (still in beta but works for our needs).

So it was time to upgrade bootstrap from 4.x to 5.x for the SWH webapp.

The following was made to complete the upgrade while keeping same look and
feel as before:

- remove use of bootstrap loader for webpack and simplify webpack configuration

- replace use of deprecated node-sass package by sass one from Dart

- update bootstrap sass variables to override and add button style matching the
  default one from AdminLTE 3.x we were using

- adapt some CSS rules and add new ones to ensure same look and feel as before

- remove explicit use of custom form controls from bootstrap 4.x as they are now
  the standard in bootstrap 5.x through new CSS classes form-*

- update CSS classes renamed in bootstrap 5.x and adminlte 4.x, notably:

  * wrapper => app-wrapper
  * main-header => app-header
  * content => app-content
  * sidebar => app-sidebar
  * footer => app-footer
  * ml-* => ms-*
  * mr-* => me-*
  * pl-* => ps-*
  * pr-* => pe-*
  * float-left => float-end
  * float-right => float-start
  * text-left => text-start
  * text-right => text-end

- rename some data-* attributes to data-bs-*

- use btn-secondary CSS class for button style instead of btn-default

- use standard bootstrap close button for modals and alerts

- put sidebar HTML code in its own dedicated include file

- simplify forms HTML code and use new form-label CSS class

- remove no longer needed javascript hacks

- improve color theme consistency notably when focusing elements with keyboard

Upgrade highlightjs to its latest release and add a couple of new
referenced plugins adding support for new programming languages.

OptimizeCSSAssetsPlugin is no longer maintained and must be replaced by
CssMinimizerPlugin.

It implied the migration of the eslint configuration files to the
new flat format (thanks to the eslint-migrate-config CLI tool).

Using a postcss plugin now results in a lot of displayed warnings so
prefer to use a dedicated webpack plugin to trigger CSS linting.

Antoine Lambert authored 1 year ago and Antoine Lambert committed 1 year ago

When searching for origins with the Web UI, if the search pattern is equal
to the URL of an archived origin then user gets automatically redirected to
the interface for browsing it.

Previously the visit type was not taken into account prior performing the
redirection so ensure to redirect only if the origin has a visit type
that matches the selected one.

Some Jupyter notebooks rendered by the webapp might require the use of
mathjax extensions that were not available in the static assets.

So ensure those extensions are available and can be lazily loaded when
required.

Add around 30 new programming languages that can he highlighted using
the highlight.js library by registering associated hljs plugins.

Some SPDX expressions located in package.json can be invalid, full license
name instead of SPDX code for instance.

In order to workaround this type of issues, use the spdx-correct package
enabling to get correct SPDX expression from an invalid one based on
some heuristics.

Antoine Lambert authored 1 year ago and Antoine Lambert committed 1 year ago

Since pdfjs using es6 modules, the loading of the pdfjs worker is failing
in production as the web server does not include the MIME type for *.mjs
files.

So use .js extension instead of .mjs to fix the issue.

Fix all accessibility critical errors detected by IBM Equal Access
Toolkit and Axe.

Related to #4767.

For each swh-web django application, create an assets folder in application
one and move related static assets source code (js, css, ...) in it.

Also modify webpack configuration to generate bundles the following way:

  - if swh/web/<app>/assets/index.js exists, a bundle named <app> is generated

  - if swh/web/<app>/assets/<bundle>/index.js exists, a bundle named <bundle>
    is generated

After these changes, some bundles got renamed but also new ones are generated
so update django templates and js code accordingly.

Related to T4398

It was previously included in the browse application but it makes
sense to isolate it in its own application in order to easily
deactivate it if needed.

Related to T4398

Related to T4398

Display info about the number of add forge now requests (filtered or not)
below the table on the left.

Set default ordering to descending submission date.

It heavily depends on browse templates so better moving it here.

Also changes view URL from /embed/<swhid>/ to /browse/embed/<swhid>/
but keeps backward compatibility by adding a redirection from the
old URL to the new one.

Inject transitions dict into Django template instead and pass it to js.

This will prevent submission of add forge now requests with invalid
forge URLs from the Web UI and the Web API.

It enables to help debugging swh-web JavaScript errors in Sentry Web UI
by demangling transpiled, minified and bundled JavaScript in order to
view source code context obtained from stack traces in its original,
untransformed form.

It looks weird when email clients soft-wrap on smaller number
of columns; eg. Thunderbird defaults to 72 when editing in
plain text.

When sidebar is in collpased mode, it was previously flashing from expanded
to collapsed when loading a page as its state was changed using javascript.

So prefer to use a cookie describing sidebar state that can be read server
side from django and injected in templates, this way the sidebar is ensured
to be in correct state in HTML code on page load.