Cannot list Github origins

1. go to https://archive.softwareheritage.org/
2. unfold the Github section, click the magnifier next to it
3. this opens https://archive.softwareheritage.org/browse/search/?q=https://github.com/&visit_type=git&with_content=true&with_visit=true
4. which redirects to https://archive.softwareheritage.org/browse/origin/directory/?origin_url=https://github.com/&visit_type=git
5. it's a 404

It seems to me that the issue is the redirect.

(reported by @Zimmi48)

changed the description

The search mechanism redirects to a browse origin view if the search query looks like an URL and matches an origin we know by calling API GET https://archive.softwareheritage.org/api/1/origin/${q}/get/, see https://gitlab.softwareheritage.org/swh/devel/swh-web/-/blob/master/swh/web/browse/assets/browse/origin-search.js?ref_type=heads#L207 & https://gitlab.softwareheritage.org/swh/devel/swh-web/-/blob/master/assets/src/utils/functions.js#L116

• I'm not sure it is expected that https://archive.softwareheritage.org/api/1/origin/https://github.com//get/ returns a 200 (the same call with gitlab.com returns a 404)
• if it is expected maybe we should redirect to the browse origin view only if the origin has_visits ?

The issue comes from the fact we have registered somehow an origin URL equals to https://github.com/.

$ psql service=swh
psql (17.2 (Ubuntu 17.2-1.pgdg24.04+1), server 16.1 (Debian 16.1-1.pgdg110+1))
SSL connection (protocol: TLSv1.3, cipher: TLS_AES_256_GCM_SHA384, compression: off, ALPN: none)
Type "help" for help.

softwareheritage=> select * from origin where url = 'https://github.com/';
    id     |         url         
-----------+---------------------
 284921308 | https://github.com/
(1 row)

To fix the issue we should simply update the search pattern for github from https://github.com/ to https://github.com as there is no such origin URL regsitered in SWH database.

softwareheritage=> select * from origin where url = 'https://github.com';
 id | url 
----+-----
(0 rows)

But https://github.com could also be added as an origin in the future, so this won't solve the problem.

Indeed, I will go for @rboyer solution then by checking if the origin URL has at least one visit with a valid snapshot using the /origin/visit/latest/ endpoint of the Web API.

Fixed in !1385 (merged), the harder was to fix the cypress tests after this change.

mentioned in merge request !1385 (merged)

mentioned in commit e086ac5d

closed with merge request !1385 (merged)

closed with commit 7ceba5a5