Antoine Lambert authored 1 month ago and Antoine Lambert committed 4 weeks ago

When calling the content_get_data method from the storage interface,
ensure to provide all content hashes as parameter to avoid an extra
request on the storage server to fetch missing hashes.

Factorize code a bit to reuse the lookup_content function instead of
duplicating code.

Paul Wise authored 1 month ago and Antoine Lambert committed 4 weeks ago

These just result in a rejection from the archival moderation team.

The GitLab API sets the appropriate CORS headers for this to work.

Co-authored-by: Antoine Lambert <anlambert@softwareheritage.org>

When the greater_or_equal parameter is set to True and there is
no visit date greater or equal to the one passed as parameter,
this function should return None.

This fixes generated browse links in the Save Code Now Web UI
when the same origin was submitted multiple times for archival.

Antoine Lambert authored 1 month ago and Antoine Lambert committed 1 month ago

Some javascript errors could occur under certain circumstances.

Antoine Lambert authored 1 month ago and Antoine Lambert committed 1 month ago

We missed it as swh-web tests are executed with a memory storage backend.

Refs. !1391

Refs. swh/infra/sysadm-environment#5534

Related to swh/infra/sysadm-environment#5534

It allows to simplify the static files configuration with django
and to remove the use of the deprecated data_files option from
setuptools.

Bump development tools: mypy, codespell, isort, ...

Move all tools configuration in pyproject.toml.

Remove no longer needed mypy overrides.

Antoine Lambert authored 1 month ago and Antoine Lambert committed 1 month ago

A better dedicated lister has been implemented since so there is no
need to display that kind of visit type anymore.

Fixes #4829.

The has_visits field is only returned by the /origin/search endpoint.

When searching for an origin URL, the search interface redirects
to its browse interface if the origin URL exists in SWH database.

Nevertheless, it the origin could not be archived, the redirection
was still done leading to a 404 error so ensure to check the origin
has a snapshot before redirecting.

Fixes #4828.

Antoine Lambert authored 2 months ago and Antoine Lambert committed 2 months ago

Sort releases according to their version numbers instead of their names.

nodejs 18 is close to EOL and some swh-web dependencies (pdfjs for
instance) bump minimal required nodejs version to 20 so time to
upgrade.

Related to swh/infra/sysadm-environment#5534

The swh.web.settings.tests settings are now dedicated to run Python tests.

The swh.web.settings.cypress settings should be used instead in that
Makefile as they do not use postgres but sqlite3 instead.

- django rename_app is no longer needed,
- mypy execution is now properly configured (in pyproject.toml).

Antoine Lambert authored 2 months ago and Antoine Lambert committed 2 months ago

django-stubs package requires mypy >= 1.12 and its latest release
pins mypy to >= 1.14.0 which fails to validate some valid typings
related to the standard Python module email.

So bump and pin mypy to 1.13.0 to avoid typing errors in Jenkins CI.

There is a discrepancy between the config entry and the module name, so
deal with it...

This is a dict which will automatically raise a ConfigurationError when
trying to access a non-existent key.

But keep it activate for development mode (aka when using the
swh.web.settings.development config file).