Kill implicit configuration: new configuration scheme
Collaborative document : https://hackmd.io/8hxTL4XMQoO2RVKtqFqM2g
Better config system that does not rely on implicit configurations.
Related:
swh-docs#1758 swh-docs#1388 #826 (closed) #1532 (closed) swh-deposit!90 (closed) !159 (closed) swh-indexer!456 (closed) !204 (closed)
Migrated from T1410 (view on Phabricator)
Designs
Activity
mentioned in issue #1532 (closed)
mentioned in issue swh-fuse#2678 (closed)
mentioned in merge request !33 (closed)
mentioned in merge request swh-scheduler!64 (closed)
mentioned in merge request !41 (closed)
mentioned in merge request swh-scheduler!71 (closed)
mentioned in merge request swh-journal!9 (closed)
mentioned in merge request !159 (closed)
mentioned in merge request swh-loader-core!159 (closed)
mentioned in merge request swh-loader-core!162 (closed)
mentioned in merge request swh-loader-svn!47 (closed)
mentioned in merge request swh-loader-mercurial!32 (closed)
mentioned in merge request swh-loader-git!51 (closed)
mentioned in merge request swh-indexer!252 (closed)
mentioned in merge request swh-lister!160 (closed)
mentioned in merge request swh-vault!65 (closed)
mentioned in merge request !204 (closed)
mentioned in merge request swh-loader-svn!51 (closed)
mentioned in merge request swh-loader-svn!52 (closed)
added Core & foundations label
mentioned in merge request swh-loader-mercurial!47 (closed)
mentioned in merge request swh-vault!80 (closed)
mentioned in merge request swh-web!487 (closed)
mentioned in merge request swh-environment!93 (closed)
mentioned in merge request swh-loader-core!335 (closed)
mentioned in merge request swh-deposit!340 (closed)
mentioned in merge request swh-scheduler!293 (closed)
mentioned in merge request swh-loader-git!115 (closed)
mentioned in merge request swh-loader-core!341 (closed)
mentioned in merge request swh-indexer!440 (closed)
mentioned in merge request swh-indexer!456 (closed)
mentioned in issue #826 (closed)
marked this issue as related to #826 (closed)
added priority:Normal label
mentioned in commit f3efe0cd
mentioned in commit edfd0b33
mentioned in commit swh-scheduler@42462869
mentioned in commit swh-scheduler@a8bc684c
mentioned in commit swh-scheduler@abfe3db7
marked this issue as related to #1532 (closed)
mentioned in commit swh-journal@bd580500
mentioned in commit swh/infra/puppet/puppet-swh-site@01897647
assigned to @tenma
For the configuration part, I see 2 use cases:
-
rpc servers, loaders, listers, ... (swh services really): They need a simple configuration file to parse and load, with eventual checks on missing keys. In such a case, it should fail early with a clear message about what's missing (so we can fix fast and restart the service). [1]
-
cli: The need is more complex (what i gathered from your irc discussion, which I did not follow entirely). What i understood was a need to share some common part across multiple subcommands of the swh cli (typically the auth-token part). And that a merge policy was thus in order. The fail-fast property is also good here ;)
-
[1] Implementation wise, that's were
SWHConfigkinda came from. And afaik, that's not used by the swh cli. Thus, why the !159 (closed) proposal which dropped a lot of the unused code in the first place sounded sensible to me. There should be no impact on those services with that diff (well, aside the fact that I need to update their respective configuration with all that they need so no more implicit configuration ;)
-