Rework loader instantiation logic according to loader core api
The new loader.core now passes all configuration through the constructor. So no more default configuration only constructor parameters.
Note that this also updated some docstrings and type along the way.
Related to swh-core#1410
Test Plan
tox (failing until swh.loader.core > 0.17 is released)
Migrated from D5075 (view on Phabricator)
Merge request reports
Activity
Build has FAILED
Patch application report for D5075 (id=18116)
Rebasing onto 71e3b447...
Current branch diff-target is up to date.Changes applied before test
commit 727189d56849edd8481db1d6d4b7919c1e935aff Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Sun Feb 7 08:45:16 2021 +0100 Rework loader instantiation logic according to loader core api Note that this also updated some docstrings and type along the way.Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/111/ See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/111/console
-
Build has FAILED
Patch application report for D5075 (id=18119)
Rebasing onto 71e3b447...
Current branch diff-target is up to date.Changes applied before test
commit 2d6423cfd454afb07f3f309a9076f95300640936 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Sun Feb 7 08:45:16 2021 +0100 Rework loader instantiation logic according to loader core api Note that this also updated some docstrings and type along the way. Related to swh/devel/swh-core#1410Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/113/ See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/113/console
-
Build has FAILED
Patch application report for D5075 (id=18120)
Rebasing onto 71e3b447...
Current branch diff-target is up to date.Changes applied before test
commit 69b218f8e22298d21d39b11893c3045bb6cedec8 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Sun Feb 7 08:45:16 2021 +0100 Rework loader instantiation logic according to loader core api Note that this also updated some docstrings and type along the way. Related to swh/devel/swh-core#1410Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/114/ See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/114/console
Adapt according to swh-loader-core!342 (closed)
-
Build has FAILED
Patch application report for D5075 (id=18182)
Rebasing onto 71e3b447...
Current branch diff-target is up to date.Changes applied before test
commit 5ad2709b12881a8b8a65488a82d7dfc5a0cbb48c Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Sun Feb 7 08:45:16 2021 +0100 Rework loader instantiation logic according to loader core api Note that this also updated some docstrings and type along the way. Related to swh/devel/swh-core#1410Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/116/ See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/116/console
-
Build is green
Patch application report for D5075 (id=18182)
Rebasing onto 71e3b447...
Current branch diff-target is up to date.Changes applied before test
commit 5ad2709b12881a8b8a65488a82d7dfc5a0cbb48c Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Sun Feb 7 08:45:16 2021 +0100 Rework loader instantiation logic according to loader core api Note that this also updated some docstrings and type along the way. Related to swh/devel/swh-core#1410See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/118/ for more details.
75 url, 76 origin_url=None, 77 visit_date=None, 78 destination_path=None, 79 swh_revision=None, 80 start_from_scratch=False, 67 storage: StorageInterface, 68 url: str, 69 origin_url: Optional[str] = None, 70 visit_date: Optional[str] = None, 71 destination_path: Optional[str] = None, 72 swh_revision: Optional[str] = None, 73 start_from_scratch: bool = False, 74 temp_directory: str = "/tmp", 75 debug: bool = False, 76 check_revision: int = 0, 85 85 self.svn_url = url 86 86 # origin url as unique identifier for origin in swh archive 87 87 self.origin_url = origin_url if origin_url else self.svn_url 88 self.debug = self.config["debug"] 89 self.temp_directory = self.config["temp_directory"] 88 self.debug = debug 89 self.temp_directory = temp_directory 90 90 self.done = False 91 91 self.svnrepo = None 92 92 # Revision check is configurable 93 check_revision = self.config["check_revision"] 94 if check_revision["status"]: 95 self.check_revision = check_revision["limit"] 96 else: 97 self.check_revision = None 93 self.check_revision = check_revision mentioned in merge request !52 (closed)
mentioned in merge request swh-loader-core!341 (closed)
-
Build is green
Patch application report for D5075 (id=18210)
Rebasing onto 71e3b447...
Current branch diff-target is up to date.Changes applied before test
commit 7476a936423ff78f5c81af4262d3e82350deb6f0 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Sun Feb 7 08:45:16 2021 +0100 Rework loader instantiation logic according to loader core api Note that this also updated some docstrings and type along the way. Related to swh/devel/swh-core#1410See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/120/ for more details.
75 url, 76 origin_url=None, 77 visit_date=None, 78 destination_path=None, 79 swh_revision=None, 80 start_from_scratch=False, 67 storage: StorageInterface, 68 url: str, 69 origin_url: Optional[str] = None, 70 visit_date: Optional[str] = None, 71 destination_path: Optional[str] = None, 72 swh_revision: Optional[str] = None, 73 start_from_scratch: bool = False, 74 temp_directory: str = "/tmp", 75 debug: bool = False, 76 check_revision: int = 0, Some references in the commit message have been migrated:
- T1410 is now swh-core#1410
