Skip to content
Snippets Groups Projects

templates/browse/search: Slightly modify search results UI

Rename "Visit type" back to "Origin type" as this is more comprehensible for a user not familiar with SWH data model.

Rename "Visit status" to "Archiving status" and simplify some tooltips for the same reason.

Wrap some long code lines in origin search related Javascript code.

Closes #2320 (closed)


Migrated from D3348 (view on Phabricator)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Build is green

    Patch application report for D3348 (id=11867)

    Rebasing onto 25abbb1c...

    Current branch diff-target is up to date.
    Changes applied before test
    commit e82e8a25e397ffa07c55c5e380f6c4b4ca77dc71
    Author: Antoine Lambert <antoine.lambert@inria.fr>
    Date:   Wed Jun 24 16:16:12 2020 +0200
    
        templates/browse/search: Slightly modify search results UI
        
        Rename "Visit type" back to "Origin type" as this is more comprehensible for
        a user not familiar with SWH data model.
        
        Rename "Visit status" to "Archiving status" and simplify some tooltips for
        the same reason.
        
        Wrap some long code lines in origin search related Javascript code.
        
        Closes #2320

    See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/221/ for more details.

  • Merge request was accepted

  • Antoine R. Dumont approved this merge request

    approved this merge request

  • Author Maintainer

    Rebase

  • Build is green

    Patch application report for D3348 (id=11883)

    Could not rebase; Attempt merge onto 480f5a83...

    Updating 480f5a83..e5f80ec6
    Fast-forward
     cypress/integration/origin-search.spec.js          |  2 +-
     cypress/integration/vault.spec.js                  | 79 ++++++++++++++++++++--
     swh/web/assets/src/bundles/browse/origin-search.js | 27 ++++++--
     .../assets/src/bundles/vault/vault-create-tasks.js | 35 ++++++++--
     swh/web/templates/browse/search.html               |  6 +-
     swh/web/templates/includes/vault-create-tasks.html | 22 ------
     6 files changed, 128 insertions(+), 43 deletions(-)
    Changes applied before test
    commit e5f80ec6c24c3068ccc07303638fa9e431a443d2
    Author: Antoine Lambert <antoine.lambert@inria.fr>
    Date:   Wed Jun 24 16:16:12 2020 +0200
    
        templates/browse/search: Slightly modify search results UI
        
        Rename "Visit type" back to "Origin type" as this is more comprehensible for
        a user not familiar with SWH data model.
        
        Rename "Visit status" to "Archiving status" and simplify some tooltips for
        the same reason.
        
        Wrap some long code lines in origin search related Javascript code.
        
        Closes #2320
    
    commit 48874d558e7d3a7d60ef126c8c4f80edfaf45a28
    Author: Antoine Lambert <antoine.lambert@inria.fr>
    Date:   Wed Jun 24 14:26:11 2020 +0200
    
        templates/vault-create-tasks: Improve cooking request submission UX
        
        Instead of visiting the Downloads page each time a cooking request is submitted
        simply display an HTML alert at the botom left of the viewport indicating
        vault task creation success.
        
        Use the same reporting system to display vault service related errors.
        
        Closes #2321

    See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/223/ for more details.

  • Author Maintainer

    Merge request was merged

Please register or sign in to reply
Loading