auth/backends: Simplify and improve OIDC authentication (!271) · Merge requests · Platform / Development / swh-web · GitLab

Snippets Groups Projects

Closed Antoine Lambert requested to merge generated-differential-D2876-source into generated-differential-D2876-target 5 years ago

While working on #2267 (closed), I noticed a couple of improvements could be added to the OIDC auth backend implementation:

there is no need to query the userinfo endpoint of the OIDC server when authenticating as those information can also be found in the decoded access token
use a more reliable access token expiration date (use exp timestamp in decoded token)
check groups claim is present in decoded token before trying to read it

Migrated from D2876 (view on Phabricator)

Activity

Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build is green See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1030/ for more details.
Antoine Lambert @anlambert · 5 years ago

Author Maintainer

Update some comments and docstrings.
Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/639/ See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/639/console
Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build is green See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1032/ for more details.
Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build is green See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/641/ for more details.
Antoine R. Dumont @ardumont · 5 years ago

Maintainer

lgtm
Antoine R. Dumont @ardumont · 5 years ago

Maintainer

Merge request was accepted
Antoine R. Dumont approved this merge request 5 years ago

approved this merge request
Antoine Lambert @anlambert · 5 years ago

Author Maintainer

Update: Check groups claim is present in decoded token before trying to read it.
Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/647/ See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/647/console
Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build is green See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1037/ for more details.
Antoine Lambert @anlambert · 5 years ago

Author Maintainer

Rebase
Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/649/ See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/649/console
Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build is green See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/1039/ for more details.
Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build is green See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/651/ for more details.
Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build is green See https://jenkins.softwareheritage.org/job/DWAPPS/job/cypress-diff/653/ for more details.
Antoine Lambert @anlambert · 5 years ago

Author Maintainer

Merge request was merged
Antoine Lambert closed 5 years ago

closed

Please register or sign in to reply