Skip to content
Snippets Groups Projects

Add django 4 support

Merged Antoine Lambert requested to merge anlambert/swh-web:django-4 into master
1 unresolved thread

Bump django to its latest version and fix tests failing with this upgrade.

It also enables to remove the version restriction on psycopg2.

However, upstream django-js-reverse requirement is not compatible with django 4.x so we have to use a patched version.

Related to #4734 (closed)

Edited by Antoine Lambert

Merge request reports

Pipeline #1138 passed

Pipeline passed for dc941b98 on anlambert:django-4

Approved by

Merged by Antoine LambertAntoine Lambert 2 years ago (Feb 23, 2023 5:58pm UTC)

Pipeline #1139 passed

Pipeline passed for dc941b98 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
50 50 Thunderbird/91.8.0
51 51 To: ${requestData.forge_contact_email}
52 52 Cc: ${requestInboundEmailAddress}
53 Reply-To: ${requestInboundEmailAddress}
  • Author Maintainer

    With django 4, there is an extra line break inserted between Reply to: and the email address, I did not understand why but this does not look critical so I removed that line from the test email content.

  • Please register or sign in to reply
  • Jenkins job DWAPPS/gitlab-builds #56 succeeded .
    See Console Output and Coverage Report for more details.

  • Antoine Lambert changed the description

    changed the description

  • mentioned in issue #4734 (closed)

  • Antoine R. Dumont approved this merge request

    approved this merge request

  • Antoine Lambert added 6 commits

    added 6 commits

    • a183700b - 1 commit from branch swh/devel:master
    • 8d70b803 - browse/directory: Redirect to content view when path targets a file
    • 2516b1cd - add_forge_now/tests: Fix pytest warning
    • 97645f40 - cypress: Fix test failing with django 4.x
    • 40c45906 - banners/tests: Fix test failing with django 4.x
    • dc941b98 - requirements: Bump django to its latest version (4.x)

    Compare with previous version

  • Author Maintainer

    ^ Rebase

  • Jenkins job DWAPPS/gitlab-builds #61 succeeded .
    See Console Output and Coverage Report for more details.

  • Please register or sign in to reply
    Loading