Paul Wise authored 2 months ago and Antoine Lambert committed 1 month ago

These just result in a rejection from the archival moderation team.

The GitLab API sets the appropriate CORS headers for this to work.

Co-authored-by: Antoine Lambert <anlambert@softwareheritage.org>

When searching for an origin URL, the search interface redirects
to its browse interface if the origin URL exists in SWH database.

Nevertheless, it the origin could not be archived, the redirection
was still done leading to a 404 error so ensure to check the origin
has a snapshot before redirecting.

Fixes #4828.

The bootstrap admin theme we are using (AdminLTE) recently added support for
bootstrap 5.x in its 4.0 release (still in beta but works for our needs).

So it was time to upgrade bootstrap from 4.x to 5.x for the SWH webapp.

The following was made to complete the upgrade while keeping same look and
feel as before:

- remove use of bootstrap loader for webpack and simplify webpack configuration

- replace use of deprecated node-sass package by sass one from Dart

- update bootstrap sass variables to override and add button style matching the
  default one from AdminLTE 3.x we were using

- adapt some CSS rules and add new ones to ensure same look and feel as before

- remove explicit use of custom form controls from bootstrap 4.x as they are now
  the standard in bootstrap 5.x through new CSS classes form-*

- update CSS classes renamed in bootstrap 5.x and adminlte 4.x, notably:

  * wrapper => app-wrapper
  * main-header => app-header
  * content => app-content
  * sidebar => app-sidebar
  * footer => app-footer
  * ml-* => ms-*
  * mr-* => me-*
  * pl-* => ps-*
  * pr-* => pe-*
  * float-left => float-end
  * float-right => float-start
  * text-left => text-start
  * text-right => text-end

- rename some data-* attributes to data-bs-*

- use btn-secondary CSS class for button style instead of btn-default

- use standard bootstrap close button for modals and alerts

- put sidebar HTML code in its own dedicated include file

- simplify forms HTML code and use new form-label CSS class

- remove no longer needed javascript hacks

- improve color theme consistency notably when focusing elements with keyboard

Antoine Lambert authored 1 year ago and Antoine Lambert committed 1 year ago

When searching for origins with the Web UI, if the search pattern is equal
to the URL of an archived origin then user gets automatically redirected to
the interface for browsing it.

Previously the visit type was not taken into account prior performing the
redirection so ensure to redirect only if the origin has a visit type
that matches the selected one.

This will prevent submission of add forge now requests with invalid
forge URLs from the Web UI and the Web API.

Promise was returned instead of the expected asynchronous result which
was causing issues when submitting save code now requests.

Implementation wise, this extracts and reuses an already defined function to compute
such date.

Related to T4074

We get a couple of these every week.

Ensure to declare a variable with const when it is not reassigned.

When a save code now request is submitted for a github repository,
ensure to use the canonical repository URL by getting it from the
github Web API.

The purpose is to avoid adding duplicated github origins in the
archive.

Related to T1110
Related to T2187

When the user searches with a valid, archived URL, it makes more sense
to redirect directly to the browse page rather than showing search
results.Two generic functions added are 'isValidURL' and
'isArchivedOrigin'. Both returns boolean.

This is more consistent to organize web assets sources and
configuration this way.

It does not make sense to allow this for a git origin.

Previously URL of type https://forge.example.org/user/project/sub-project/ were
not validated by the isGitRepoUrl function.

Closes T2331

Use dismissible bootstrap alerts instead of modals.

To ease copy/paste of source code or web api response for instance,
add the possibility to select the whole content of a code/pre element
using double click or the following procedure:

  1. click inside the code/pre element to make it the focus

  2. hit Ctrl+A to select all its textual content

Closes T1429

Closes T1186

Closes T1118

This commit fixes bad license name in some Python files (swh-web is
AGPL not GPL) but also adds license header in static assets related
source files (html, js, css).

This commit improves frontend development for swh web applications
by setting up a static assets pipeline using the module bundler tool
webpack. It enables to organize frontend development into logical
modules and then package those modules into multiple bundles that
will be loaded when required by client browsers.

This induces the following changes (see updated README):

  - node.js is now a requirement for developping swh-web

  - all static assets dependencies (javascript libraries, stylesheets,
    web fonts) are now managed and retrieved using npm.

  - all static assets will now be served through our web server

Regarding the webpack workflow put in place, it offers the following
features:

  - automatic linting of custom javascript and stylesheets in order
    to have a consistent code style and avoid bad pratices

  - the possibility to use es6 syntax and recent javascript features
    (like async/await) through the use of babel (es6 to es5 transpiler)

  - leverage the use of webpack-dev-server in development mode
    in order to automatically reload web applications in the browser
    when modifying source files

  - in production mode, minify javascript and stylesheets but also
    perform dead code elimination in order to reduce bundle sizes and
    thus optimize the amount of data to serve to the clients.

Closes T1006