Add `algos.identifier.identifiers_missing`

This is a small wrapper around the underlying *_missing functions in order to assist with looking up missing SWHIDs.

This will be a building block to clean up some things in swh-web so that swh-web#4224 (closed) doesn't come back.

---

Migrated from D7751 (view on Phabricator)

Fix spelling error

Build has FAILED

Patch application report for D7751 (id=28025)

Rebasing onto 95629534...

Current branch diff-target is up to date.

Changes applied before test

commit 31d4c3e4cfee780a1e3c823ef132e216705d8704
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Thu May 5 13:25:57 2022 -0400

    Add `algos.identifier.identifiers_missing`
    
    This is a small wrapper around the underlying `*_missing` functions in
    order to assist with looking up missing SWHIDs.
    
    This will be a building block to clean up some things in swh-web so that
    https://forge.softwareheritage.org/swh/devel/swh-web#4224 doesn't come back.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1605/ See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1605/console

Build has FAILED

Patch application report for D7751 (id=28026)

Rebasing onto 95629534...

Current branch diff-target is up to date.

Changes applied before test

commit 026af46d2e36b5c40309ad1a1c13549167c2ff2e
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Thu May 5 13:25:57 2022 -0400

    Add `algos.identifier.identifiers_missing`
    
    Summary:
    This is a small wrapper around the underlying `*_missing` functions in
    order to assist with looking up missing SWHIDs.
    
    This will be a building block to clean up some things in swh-web so that
    https://forge.softwareheritage.org/swh/devel/swh-web#4224 doesn't come back.
    
    Reviewers: #reviewers
    
    Differential Revision: https://forge.softwareheritage.org/!788

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1606/ See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1606/console

Ensure thre is an error on invalid object type

Condense / deduplicate to the code too in the process.

Build has FAILED

Patch application report for D7751 (id=28027)

Rebasing onto 95629534...

Current branch diff-target is up to date.

Changes applied before test

commit a92cef818b5a2b947f2cf733283c3f28116a2797
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Thu May 5 13:25:57 2022 -0400

    Add `algos.identifier.identifiers_missing`
    
    Summary:
    This is a small wrapper around the underlying `*_missing` functions in
    order to assist with looking up missing SWHIDs.
    
    This will be a building block to clean up some things in swh-web so that
    https://forge.softwareheritage.org/swh/devel/swh-web#4224 doesn't come back.
    
    Reviewers: #reviewers
    
    Differential Revision: https://forge.softwareheritage.org/!788

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1607/ See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1607/console

Need to drain iterable to set

Build was aborted

Patch application report for D7751 (id=28028)

Rebasing onto 95629534...

Current branch diff-target is up to date.

Changes applied before test

commit 1717c3eaa70a5c8e4c73dd6ac59926e8dd9f3f8e
Author: John Ericson <John.Ericson@Obsidian.Systems>
Date:   Thu May 5 13:25:57 2022 -0400

    Add `algos.identifier.identifiers_missing`
    
    Summary:
    This is a small wrapper around the underlying `*_missing` functions in
    order to assist with looking up missing SWHIDs.
    
    This will be a building block to clean up some things in swh-web so that
    https://forge.softwareheritage.org/swh/devel/swh-web#4224 doesn't come back.
    
    Reviewers: #reviewers
    
    Differential Revision: https://forge.softwareheritage.org/!788

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1608/ See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1608/console

mentioned in merge request swh-web!802 (closed)

changed the description

added 44 commits

• a706892c...fc998737 - 43 commits from branch master
• 4c52ad79 - Add `algos.identifier.identifiers_missing`

Compare with previous version

enabled an automatic merge when the pipeline for 4c52ad79 succeeds

canceled the automatic merge

While reviewing the current pending merge requests, this one felt stalled. Please re-open if you are still interested in working on it. Thanks for your contributions!

closed