Skip to content
Snippets Groups Projects

Fix boolean mapping in metadata document

2 unresolved threads

Ensure all the fields metadata.* are created as a string in the mapping

Related to swh/infra/sysadm-environment#3373 (closed)

This mapping change will imply to recreate the index and reindex all the data (origins + metadata)


Migrated from D5867 (view on Phabricator)

Merge request reports

Approved by

Closed by Phabricator Migration userPhabricator Migration user 3 years ago (Jun 16, 2021 1:36pm UTC)

Merge details

  • The changes were not merged into generated-differential-D5867-target.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
513 513 "@context": "https://doi.org/10.5063/schema/codemeta-2.0",
514 514 "dateCreated": "2021-02-18T10:16:52",
515 515 "version": "1.0",
516 "isAccessibleForFree": True,
  • 528 528 "dateCreated": "a long time ago",
    529 529 "address": "in a galaxy far, far away",
    530 530 "version": "a new hope",
    531 "isAccessibleForFree": "it depends",
  • You should rename the test, it doesn't just test the date anymore

  • Author Maintainer

    Thanks, the diff is updated according to your reviews:

    • rename the test to something more generic
    • add searches on the boolean field
  • Build is green

    Patch application report for D5867 (id=21058)

    Rebasing onto 8b2c87f4...

    Current branch diff-target is up to date.
    Changes applied before test
    commit 69364b3b0aca84c211f83b5cbb664a828a552a34
    Author: Vincent SELLIER <vincent.sellier@softwareheritage.org>
    Date:   Tue Jun 15 10:02:54 2021 +0200
    
        Fix boolean mapping in metadata document
        
        Ensure all the fields metadata.* are created as a string in the mapping
        
        Related to swh/infra/sysadm-environment#3373

    See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/141/ for more details.

  • Merge request was accepted

  • vlorentz approved this merge request

    approved this merge request

  • Author Maintainer

    Merge request was merged

  • Please register or sign in to reply
    Loading