Skip to content
Snippets Groups Projects

(ci: unstuck master build) search: cli: Rename --max-messages to --stop-after-objects

1 unresolved thread

Following the journal migration (v0.0.27).

This will unstuck the current aborted build on master [1]

Similar to swh-indexer!228 (closed) Related to swh-journal!123 (closed)

Test Plan

tox


Migrated from D2897 (view on Phabricator)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
65 65 )
66 66 nb_messages = 0
67 67 try:
68 while not max_messages or nb_messages < max_messages:
69 nb_messages += client.process(worker_fn)
70 print('Processed %d messages.' % nb_messages)
68 nb_messages = client.process(worker_fn)
69 print('Processed %d messages.' % nb_messages)
71 70 except KeyboardInterrupt:
72 71 ctx.exit(0)
73 72 else:
74 73 print('Done.')
74 finally:
  • Thanks for trying to fix this. A few comments inline regarding the JournalClient usage pattern.

  • Merge request was returned for changes

  • Right, i forgot to check but i remembered something about that. I'll also adapt the indexer's journal client which does something similar as this diff (without your remarks applied i mean)

  • Adapt according to review

    Needs swh-journal!139 (closed) for the tests to go green

  • mentioned in merge request swh-journal!139 (closed)

  • mentioned in merge request swh-indexer!230 (closed)

  • Merge request was accepted

  • Nicolas Dandrimont approved this merge request

    approved this merge request

  • Merge request was merged

  • Please register or sign in to reply
    Loading