Skip to content
Snippets Groups Projects

Improve cli documentation

The docstring was moved out of scanner docstring spot to work around a bug in our current Python version. See https://bugs.python.org/issue28739

Depends on !74 (closed)


Migrated from D4090 (view on Phabricator)

Merge request reports

Closed by Phabricator Migration userPhabricator Migration user 4 years ago (Oct 2, 2020 1:27pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Build has FAILED

    Patch application report for D4090 (id=14423)

    Could not rebase; Attempt merge onto ad23ee03...

    Updating ad23ee0..1c8a302
    Fast-forward
     swh/scanner/cli.py            | 57 +++++++++++++++++++----------
     swh/scanner/tests/test_cli.py | 83 +++++++++++++++++++++++++++++++++++++++++++
     2 files changed, 121 insertions(+), 19 deletions(-)
     create mode 100644 swh/scanner/tests/test_cli.py
    Changes applied before test
    commit 1c8a302129e33704359d721cde805b8a3bbd647c
    Author: tenma <tenma+swh@mailbox.org>
    Date:   Tue Sep 29 19:47:54 2020 +0200
    
        Improve cli documentation
        
        The docstring was moved out of scanner docstring spot to work around a
        bug in our current Python version. See https://bugs.python.org/issue28739
    
    commit d4e8857620cf95df324e47046337e7180b0d90f2
    Author: tenma <tenma+swh@mailbox.org>
    Date:   Tue Sep 29 19:22:24 2020 +0200
    
        Add tests and fix behavior of scanner cli
        
        - add smoke and unit tests
        - fix behavior of cli in case an invalid config file is specified via
        envvar

    Link to build: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/54/ See console output for more information: https://jenkins.softwareheritage.org/job/DTSCN/job/tests-on-diff/54/console

  • Hm I submitted 2 times this commit, but the last one is !76 (closed). Sorry I will close this. Config related code will go to core.config, yes, when it will be ready for it.

  • Merge request was abandoned

  • closed

Please register or sign in to reply
Loading