@olasdthese are the failed dependencies you told me to expect, right? The missing package is ... libcmph-dev.
16:26:08 In file included from build/temp.linux-x86_64-3.7/_hash_cffi.c:570:16:26:08 ./swh/perfecthash/hash.h:1:10: fatal error: cmph.h: No such file or directory16:26:08 #include <cmph.h>16:26:08 ^~~~~~~~16:26:08 compilation terminated.16:26:08 error: command 'x86_64-linux-gnu-gcc' failed with exit status 1
@olasd I'd like to add dependencies to the CI job running swh-perfecthash (valgrind) so that it can verify the C implementation is clean. Would you be so kind as to point me in the right direction? I looked in https://forge.softwareheritage.org/source/swh-jenkins-jobs but could not find the keyword cmph and concluded it must be in another repository.
Now there is a need to run tox -e c for this job only. I think it means doing something similar to running mypy but not for all jobs, just this one. I'd be grateful if you could point me in the right direction.
Loïc Dacharymarked the checklist item Add to swh-environment as completed
marked the checklist item Add to swh-environment as completed
cd swh-docsSPHINXOPTCOLOR='--no-color' tox -e sphinxfirefox docs/_build/html/
It looks ok.
Except for one thing (which is the main thing really ): the API reference is missing. I don't see an error that would explain why and I see swh-environment/swh-perfecthash/docs/apidoc/swh.perfecthash.rst exists and should be taken into account. Any idea as to why this is happening?
@olasd I split the debian packaging in its own task at #3797 so that this task can be closed. I'll let you revert this if you think it is not appropriate. My rationale is that it would be easier to figure out what's left to be done with this one other task. Rather than coming back to this rather overloaded ticket. But it's just a matter of personal taste :-)