model.hypothesis_strategies: Make metadata always none on origin_visit

1. This is not currently not used in production.

2. This is broken storage side [1]

3. And finally, this is temporary as this will soon go away with T2310 - [2]

• [1] origin-visit-add does not deal correctly with metadata (origin-visit-status-add does it well though). And it so happens there is no test around it... So unfortunately it only got detected by @douardda's run with the backfiller or something. It's good it got detected though ¯_(ツ)_/¯

• [2] we are currently phasing out multiple origin-visit fields including this one

Test Plan

tox

---

Migrated from D3294 (view on Phabricator)

Some references in the commit message have been migrated:

• T2310 is now swh/meta#2310 (closed)

Build is green

Patch application report for D3294 (id=11675)

Rebasing onto f723eb12...

Current branch diff-target is up to date.

Changes applied before test

commit ba0c4e19e6b01f0c9585832f7fe430975f48ab8c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Tue Jun 16 19:10:53 2020 +0200

    model.hypothesis_strategies: Make metadata always none on origin_visit
    
    This is not used. This is broken storage wise (origin-visit-add does not deal
    correctly with it and it so happens there is no test around it).
    
    And finally, this will soon go away with [T2310](https://forge.softwareheritage.org/T2310 'view original for T2310 on Phabricator').

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/74/ for more details.

Merge request was accepted

approved this merge request

Merge request was merged

closed

mentioned in merge request swh-journal!177 (closed)