Use origin urls instead of origin ids (swh-loader-svn)
Closed
requested to merge generated-differential-D1597-source into generated-differential-D1597-target
1 unresolved thread
As a side-effect, start using snapshot_get_all_branches, although it's probably pointless in a subversion loader.
Migrated from D1597 (view on Phabricator)
Merge request reports
Activity
Filter activity
Build is green See https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/36/ for more details.
135 136 self.svnrepo.clean_fs(local_dirname) 136 137 return h 137 138 138 def get_svn_repo(self, svn_url, local_dirname, origin_id): 139 def get_svn_repo(self, svn_url, local_dirname, origin_url): 139 140 """Instantiates the needed svnrepo collaborator to permit reading svn 140 141 repository. 141 142 142 143 Args: 143 144 svn_url (str): the svn repository url to read from 144 145 local_dirname (str): the local path on disk to compute data 145 origin_id (int): the corresponding origin id 146 origin_url (str): the corresponding origin url mentioned in issue swh-storage#1816 (closed)
! In !13 (closed), @ardumont wrote: Did you rework the loader-core already?
No, it will come last, because it sets a
self.origin_id
, which is used by many loaders, so I need to drop it from the loaders first.Build has FAILED
Link to build: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/37/ See console output for more information: https://jenkins.softwareheritage.org/job/DLDSVN/job/tox/37/console
Please register or sign in to reply