Skip to content
Snippets Groups Projects

Use origin urls instead of origin ids (swh-loader-svn)

1 unresolved thread

As a side-effect, start using snapshot_get_all_branches, although it's probably pointless in a subversion loader.


Migrated from D1597 (view on Phabricator)

Merge request reports

Closed by Phabricator Migration userPhabricator Migration user 5 years ago (Jun 18, 2019 1:14pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
135 136 self.svnrepo.clean_fs(local_dirname)
136 137 return h
137 138
138 def get_svn_repo(self, svn_url, local_dirname, origin_id):
139 def get_svn_repo(self, svn_url, local_dirname, origin_url):
139 140 """Instantiates the needed svnrepo collaborator to permit reading svn
140 141 repository.
141 142
142 143 Args:
143 144 svn_url (str): the svn repository url to read from
144 145 local_dirname (str): the local path on disk to compute data
145 origin_id (int): the corresponding origin id
146 origin_url (str): the corresponding origin url
  • Sounds good.

    Did you rework the loader-core already?

  • Merge request was accepted

  • Antoine R. Dumont approved this merge request

    approved this merge request

  • Author Maintainer

    type

  • Author Maintainer

    Merge request was merged

  • closed

  • Author Maintainer

    ! In !13 (closed), @ardumont wrote: Did you rework the loader-core already?

    No, it will come last, because it sets a self.origin_id, which is used by many loaders, so I need to drop it from the loaders first.

  • Please register or sign in to reply
    Loading