cvsclient: Align commands to checkout a file with git cvsimport ones

When using pserver protocol, the previous implementation could fail to checkout some files while it is working fine when using the cvsimport command from git.

So align the pserver commands sent to checkout a file with the ones used in the git cvsimport implementation as it effectively fixes the observed file checkout issues.

Related to #4650 (closed).

Fixes SWH-LOADER-CVS-4E.

Jenkins job DLDCVS/gitlab-builds #28 succeeded .
See Console Output and Coverage Report for more details.

changed the description

approved this merge request

I guess this one should be a bit monitored once deployed.

For the record, the sole CVS origins we are listing comes from sourceforge and use the rsync protocol (much faster than pserver to retrieve repo data) but some CVS origins using pserver can be submitted by a save code now request.

I tested the loading of some pserver origins after this change and did not detect any failure so far.

The fix is deployed in staging.

Do you want to do some checks before the production deployment?

For the record, the staging's SCN logs can be consulted here: http://kibana0.internal.softwareheritage.org:5601/goto/529c1d2be49d288d2eb82d13646a3b34

I have created three CVS (pserver based) save requests on staging: one failed but expected as remote is down, the two other succeeded notably pserver://anonymous@cvs.osdn.net/cvsroot/canna/canna who failed to be loaded before this MR.

You can safely deploy to production.

thanks, deployment done in production

merged