Skip to content

phabricator.lister: Use credentials setup from config file

Antoine R. Dumont requested to merge generated-differential-D1588-source into generated-differential-D1588-target

Prior to this commit, this expected the api.token to be provided at task initialization. That behavior has been kept for cli purposes. It's no good for production purposes though (as this leaks the credentials in the scheduler db).

So now, the credentials is fetched from the lister's configuration file as the other listers do.

Another change is the authentication mechanism which is slighly different. It's not using a basic auth mechanism. It's expecting an api.token query parameter so the request_params is overriden to provide that.

Related #1809 (closed)

Annex: gitlab.lister: Remove request_params method override (as the default implementation is generic enough for most listers since b8162127). This should have been removed in that same commit.

Related b8162127 Related swh/infra/puppet/puppet-swh-site#1772 (closed)

Test Plan

tox

docker-dev ~> listed our forge with swhbot's credential

Migrated from D1588 (view on Phabricator)

Merge request reports