Skip to content
Snippets Groups Projects

feat: Add Hex.pm lister

Closed Kumar Shivendu requested to merge generated-differential-D8907-source into master
2 unresolved threads

Hex is the package manager for Erlang ecosystem.

All the source code files are available in .tar format which can be ingested by a dedicated loader

Related to #4687 (closed)


Migrated from D8907 (view on Phabricator)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
27 27 - `swh.lister.tuleap`
28 28 - `swh.lister.gogs`
29 29 - `swh.liser.fedora`
30 - `swh.lister.hex`
  • vlorentz
    vlorentz @vlorentz started a thread on the diff
  • 87 87 lister.maven=swh.lister.maven:register
    88 88 lister.gogs=swh.lister.gogs:register
    89 89 lister.fedora=swh.lister.fedora:register
    90 lister.hex=swh.lister.hex:register
  • You need to pass complete_qs to requests_mock to actually test the query string: https://requests-mock.readthedocs.io/en/latest/matching.html#query-strings (and then you'll need to add the sort param, because it's missing from tests).

    Did you test incremental listings? the sort value looks wrong (should be updated_at instead of name), but if you change it, then pagination is unusable because it's offset-based. Looks like this API is too badly designed to support it.

  • Merge request was returned for changes

  • Author Contributor

    but if you change it, then pagination is unusable because it's offset-based.

    Exactly. That's why I went with sort=name (which changes less frequently than the latest package version release date)

    Thanks for https://github.com/hexpm/hexpm/pull/1168. But there's one more issue. ?sort=updated_at actually works in DESC order only. So it will make search=updated_after:xyz ineffective on the next pages.

    We need to choose one of the following options:

    • add a new query param ?order=DESC
    • replace updated_after with updated_before
  • order sounds best. Do you want to do it?

  • Author Contributor

    order sounds best. Do you want to do it?

    Sure. Thanks!

  • Author Contributor

    Created these in Hex.pm official github repo:

  • Kumar Shivendu mentioned in merge request !457 (merged)

    mentioned in merge request !457 (merged)

  • replaced by !457 (merged)

  • closed

  • Please register or sign in to reply
    Loading