Skip to content

Phabricator: Prevent erroneous scheduler tasks disabling

Antoine Lambert requested to merge generated-differential-D1990-source into generated-differential-D1990-target

This diff contains the set of fixes for the issues noticed while working on D1982.

Previously, the Phabricator lister was disabling some loading tasks while it was not supposed to. More precisely, due to an invalid index provided to a database query, the latest created scheduler task was disabled each time a new page of results was provided to the lister by the Phabricator API. Moreover, database queries were not filtered according to the Phabricator instance resulting in possible disabling of scheduler tasks from other instances.

Closes #2000 (closed)

Depends on !100 (closed)

Test Plan

New tests have been added for both task disabling cases.

I have the feeling that we could encounter such issues in other indexing listers. Maybe the new tests could be moved in base testing class to check all listers behave correctly regarding scheduler tasks creation.

Migrated from D1990 (view on Phabricator)

Merge request reports