Phabricator: Fix get_next_target_from_response return type (!100) · Merge requests · Platform / Development / swh-lister · GitLab

Snippets Groups Projects

Closed Antoine Lambert requested to merge generated-differential-D1984-source into generated-differential-D1984-target 5 years ago

Without that fix, errors are raised when one wants to list Phabricator repositories in a specific index range. The issue is due to a comparison between a string and an integer. So convert next extracted repository index to integer to match the corresponding model type.

Depends on !99 (closed)

Closes #1997 (closed)

Test Plan

A new test has been added for range listing.

Migrated from D1984 (view on Phabricator)

Activity

Phabricator Migration user @phabricator-migration commented on commit e83902c2 5 years ago

Owner

Some references in the commit message have been migrated:

T1997 is now #1997 (closed)
Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build is green See https://jenkins.softwareheritage.org/job/DLS/job/tox/368/ for more details.
Antoine R. Dumont mentioned in merge request !101 (closed) 5 years ago

mentioned in merge request !101 (closed)
Antoine R. Dumont @ardumont · 5 years ago

Maintainer

Merge request was accepted
Antoine R. Dumont approved this merge request 5 years ago

approved this merge request
Antoine Lambert @anlambert · 5 years ago

Author Maintainer

Merge request was merged
Antoine Lambert closed 5 years ago

closed

Please register or sign in to reply