Draft: Add an Id field to the snapshot branch object

Client can use this Id as a cache key.

Shouldn't ids be globally unique? This one seems to be based on the branch name, which is only locally unique

Don't have to be globally unique for the cache to work, it is basically for the cache manager to dynamically adjust the "before" and "after" args along with the cursor. So, it will always be inside the connection context.

As of now the only way to fetch a list of branches is inside a snapshot. But this will be a problem when we have another way to fetch a list of branches. Say, search all the branches from an origin across snapshots with a given name. So, I think it is better to make this Id <snapshot_id>:<branch_name> to a safe. Then I will wait for !88 (merged) and move this to draft.

marked this merge request as draft

added 2 commits

• 82b36674 - 1 commit from branch master
• 02fbfa66 - Add an Id field to the snapshot branch object

Compare with previous version

closed