Add type annotations for base_connection
1 unresolved thread
Closed
requested to merge generated-differential-D8065-source into generated-differential-D8065-target
1 unresolved thread
Remove unnecessary functions in base_connection; properties can be overridden directly in the sub class
Related to #4261 (closed)
Migrated from D8065 (view on Phabricator)
Merge request reports
Activity
Filter activity
Build is green
Patch application report for D8065 (id=29102)
Rebasing onto 836eddb7...
Current branch diff-target is up to date.
Changes applied before test
commit 254e8f55b62e5916171320ab7c3d29d2a3561e70 Author: Jayesh Velayudhan <jayesh@softwareheritage.org> Date: Fri Jul 1 11:49:14 2022 +0200 Add type annotations for base_connection Remove unnecessary functions in base_connection; properties can be overridden directly in the sub class Related to #4261
See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/79/ for more details.
Build is green
Patch application report for D8065 (id=29103)
Rebasing onto 836eddb7...
Current branch diff-target is up to date.
Changes applied before test
commit e4aeeee8bce206f1b6a6336ca4174a5cd34bdc13 Author: Jayesh Velayudhan <jayesh@softwareheritage.org> Date: Fri Jul 1 11:49:14 2022 +0200 Add type annotations for base_connection Remove unnecessary functions in base_connection; properties can be overridden directly in the sub class Related to #4261
See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/80/ for more details.
76 77 def _get_total_count(self): 81 def totalCount(self) -> Optional[int]: # To support the schema naming convention 78 82 """ 79 83 Will be None for most of the connections 80 84 override if needed/possible 81 85 """ 86 82 87 return None 83 88 84 def get_paged_data(self): 89 def get_paged_data(self) -> PagedResult: 85 90 """ 86 Cache to avoid multiple calls to 87 the backend (_get_paged_result) 91 Cache to avoid multiple calls to the backend :meth:`_get_paged_result` Some references in the commit message have been migrated:
- T4261 is now #4261 (closed)
Build is green
Patch application report for D8065 (id=29105)
Rebasing onto 836eddb7...
Current branch diff-target is up to date.
Changes applied before test
commit e4d4a30b1f3665204404e44f4a79f4235a063f79 Author: Jayesh Velayudhan <jayesh@softwareheritage.org> Date: Fri Jul 1 11:49:14 2022 +0200 Add type annotations for base_connection Remove unnecessary functions in base_connection; properties can be overridden directly in the sub class Related to #4261
See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/81/ for more details.
Please register or sign in to reply