add tests for parameter validation

note that this requires a change in swh-core's RPCClient (exposing self.check_status(), see swh-core!97 (closed)) that is not pushed yet, so CI will fail

---

Migrated from D2265 (view on Phabricator)

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/95/ See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/95/console

Could you make the tests check for the error message? (with raises(RemoteException, match='regexp'):)

Merge request was returned for changes

! In !150 (closed), @vlorentz wrote: Could you make the tests check for the error message? (with raises(RemoteException, match='regexp'):)

I really think that's an antipattern. If anything, we should stop doing it elsewhere rather than adding it in more places. If the type of error matters (which is arguably the case here), it should be captured by exception attributes other than a human readable message, e.g., exception type, exception properties, etc.

That would be ok with me.

• client.py: renamse check_status -> raise_for_status
• test_api_client: check HTTP status codes for bad requests

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/100/ See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/100/console

! In !150 (closed), @vlorentz wrote: That would be ok with me.

Now done. With the last changes in swh-core!97 (closed) we can now check that the returned HTTP status codes here are correct.

Merge request was accepted

approved this merge request

• add tests for parameter validation
• client.py: renamse check_status -> raise_for_status
• test_api_client: check HTTP status codes for bad requests

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/106/ See console output for more information: https://jenkins.softwareheritage.org/job/DGRPH/job/tox/106/console

• add tests for parameter validation
• client.py: renamse check_status -> raise_for_status
• test_api_client: check HTTP status codes for bad requests
• test_api_client.py: do not test /walk parameter validation

Build is green See https://jenkins.softwareheritage.org/job/DGRPH/job/tox/109/ for more details.

Merge request was merged

closed