Skip to content

Separate loader-deposit from other loaders

Antoine R. Dumont requested to merge generated-differential-D5102-source into generated-differential-D5102-target

Fix the build [1]

Loaders have been reworked to only deal with configuration as constructor parameters. As the current docker configuration is shared amongst all loaders, this can no longer work.

The current "next-gen" loaders share a subset of those configuration though so most can run together. Except for the loader deposit which needs dedicated extra keys (deposit, url).

Note that some configuration keys (scheduler for example) referenced in the current configuration are not for loaders. This make instantiation fails. So they need to be removed.

All in all, trying to separate the dedicated deposit loader with its configuration in its own container and let the other loaders running as before fixes the build.

That and stop referecing the scheduler configuration in the loader configuration. Instead use a dedicated environment variable to specify the scheduler url to use.

Related to swh-core#1410

Test Plan

tox happy (finally)

...
___________________________________________________________________________________________________________________ summary ___________________________________________________________________________________________________________________
  flake8: commands succeeded
  py3: commands succeeded
  shell_tests: commands succeeded
  congratulations :)

Migrated from D5102 (view on Phabricator)

Merge request reports