Add isort pre-commit hook and configuration to all repos

added Development environment priority:Normal labels

+1 to the idea (and to the specific config as I have already bikeshed it)

You might need to skip .py files in tests/*/data (eg. swh-web iirc)

LGTM

(I was initially surprised by the mixing together of "import" lines with "from ... import" ones, but upon reflection it makes a lot of sense, because one might have to switch between the two forms, and it's silly to have to move the line back and forth between import blocks when that happens.)

You might need to skip .py files in tests/*/data (eg. swh-web iirc)

Right ! Once global isort config will be pushed to repos, I will update swh-web!404 (closed) with specific swh-web configuration only (django import grouping, paths exclusion).

mentioned in commit swh-core@ba8a9783

Ok so the plan to integrate isort in all repos will be the following:

Integrate the following diff (manually) in all repos using the change-all-repos script from @vlorentz but do not push to remote yet

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
index 5ab0e08..df70797 100644
--- a/.pre-commit-config.yaml
+++ b/.pre-commit-config.yaml
@@ -26,6 +26,11 @@ repos:
     language: system
     types: [python]
 
+- repo: https://github.com/PyCQA/isort
+  rev: 5.5.2
+  hooks:
+  - id: isort
+
 - repo: https://github.com/python/black
   rev: 19.10b0
   hooks:
diff --git a/pyproject.toml b/pyproject.toml
index b5413f6..206af2c 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,2 +1,12 @@
 [tool.black]
 target-version = ['py37']
+
+[tool.isort]
+multi_line_output = 3
+include_trailing_comma = true
+force_grid_wrap = 0
+use_parentheses = true
+ensure_newline_before_comments = true
+line_length = 88
+force_sort_within_sections = true
+

Run make check in all repos to apply imports ordering
Run make test in all repos to check and fix possible side effects
Once it is done, add a new commit for the imports ordering
Push to remotes

mentioned in commit swh-dataset@c33e8ea7

mentioned in commit swh-deposit@52c057db

mentioned in commit swh-docs@b60869d8

mentioned in commit swh-graph@ecb7cca2

mentioned in commit swh-icinga-plugins@832a11a6

mentioned in commit swh-indexer@c6fcd222

mentioned in commit swh-journal@b5969a7a

mentioned in commit swh-lister@d24846a9

mentioned in commit swh-loader-core@cc2ffe15

mentioned in commit swh-loader-git@152eece9

mentioned in commit swh-loader-mercurial@21a66f4f

mentioned in commit swh-model@5bda22fb

mentioned in commit swh-objstorage@35a796bf

mentioned in commit swh-objstorage-replayer@915721a1

mentioned in commit swh-py-template@53ca9e43

mentioned in commit swh-scanner@64381b25

mentioned in commit swh-search@9b7516f4

mentioned in commit swh-storage@d27a0464

mentioned in commit swh-vault@cf35fb7e

mentioned in commit swh-web@d24922fc

mentioned in commit swh-web-client@814057d3

mentioned in commit swh-loader-svn@c1ac9322

mentioned in commit swh-scheduler@8d8b58f4

mentioned in commit swh-core@28d61c8c

Ok so I applied the above process locally and no bad surprises when running all test suites. I will push the changes to remote then and close that task once it is done.