Skip to content
Snippets Groups Projects

Get rid of the arrow datetime format in swh.core.api.serializers

1 unresolved thread

Depends on !200 (closed)


Migrated from D4684 (view on Phabricator)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
67 "days": o.days,
68 "seconds": o.seconds,
69 "microseconds": o.microseconds,
70 },
71 ),
72 69 (UUID, "uuid", str),
70 (datetime.timedelta, "timedelta", encode_timedelta),
73 71 (PagedResult, "paged_result", _encode_paged_result),
74 72 # Only for JSON:
75 73 (bytes, "bytes", lambda o: base64.b85encode(o).decode("ascii")),
76 74 (Exception, "exception", exception_to_dict),
77 75 ]
78 76
79 DECODERS = {
80 "arrow": arrow.get,
77 DECODERS: Dict[str, Callable] = {
  • Build is green

    Patch application report for D4684 (id=16623)

    Could not rebase; Attempt merge onto 68a35f8a...

    Updating 68a35f8..1496888
    Fast-forward
     swh/core/api/serializers.py            | 35 +++++++---------------
     swh/core/api/tests/test_serializers.py | 53 ++++------------------------------
     2 files changed, 16 insertions(+), 72 deletions(-)
    Changes applied before test
    commit 14968882ae77bfb60f3aea29209ed15ae97635b2
    Author: David Douard <david.douard@sdfa3.org>
    Date:   Tue Dec 8 12:11:58 2020 +0100
    
        Get rid of the arrow datetime format in swh.core.api.serializers
        
        it should not be used anymore.
    
    commit 5bbbba6197d8319668be2970876b6f6e29b0b248
    Author: David Douard <david.douard@sdfa3.org>
    Date:   Tue Dec 8 11:45:52 2020 +0100
    
        Drop support for legacy msgpack encodings in msgpack_loads
        
        we should be free of them by now. The journal has been recreated from
        scratch since then.

    See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/174/ for more details.

  • mentioned in merge request swh-web!466 (closed)

  • With the removal in requirements.txt :-)

  • Merge request was accepted

  • Nicolas Dandrimont approved this merge request

    approved this merge request

  • Author Maintainer

    and requirements-http.txt

  • (note the inline comment, I guess I was wrong and the explicit Callable annotation should be enough.)

  • Merge request was accepted

  • Nicolas Dandrimont approved this merge request

    approved this merge request

  • Build is green

    Patch application report for D4684 (id=16624)

    Could not rebase; Attempt merge onto 68a35f8a...

    Updating 68a35f8..e1c3a18
    Fast-forward
     requirements-http.txt                  |  1 -
     swh/core/api/serializers.py            | 35 +++++++---------------
     swh/core/api/tests/test_serializers.py | 53 ++++------------------------------
     3 files changed, 16 insertions(+), 73 deletions(-)
    Changes applied before test
    commit e1c3a18f43fe5b7562976dad740773d212de74f8
    Author: David Douard <david.douard@sdfa3.org>
    Date:   Tue Dec 8 12:11:58 2020 +0100
    
        Get rid of the arrow datetime format in swh.core.api.serializers
        
        it should not be used anymore.
    
    commit 5bbbba6197d8319668be2970876b6f6e29b0b248
    Author: David Douard <david.douard@sdfa3.org>
    Date:   Tue Dec 8 11:45:52 2020 +0100
    
        Drop support for legacy msgpack encodings in msgpack_loads
        
        we should be free of them by now. The journal has been recreated from
        scratch since then.

    See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/175/ for more details.

  • Cool, thanks ! Can you push a new tag for swh-core once landed ? This will make swh-web CI happy.

  • Author Maintainer

    ! In !201 (closed), @anlambert wrote: Cool, thanks ! Can you push a new tag for swh-core once landed ? This will make swh-web CI happy.

    I'd be happy tom but I need !200 (closed) accepted too!

  • Author Maintainer

    fix typing according to olasd's comment

  • Build is green

    Patch application report for D4684 (id=16630)

    Could not rebase; Attempt merge onto 68a35f8a...

    Updating 68a35f8..6492e61
    Fast-forward
     requirements-http.txt                  |  1 -
     swh/core/api/serializers.py            | 35 +++++++---------------
     swh/core/api/tests/test_serializers.py | 53 ++++------------------------------
     3 files changed, 16 insertions(+), 73 deletions(-)
    Changes applied before test
    commit 6492e6173e57869f04df9e04531b5a38f5335dfd
    Author: David Douard <david.douard@sdfa3.org>
    Date:   Tue Dec 8 12:11:58 2020 +0100
    
        Get rid of the arrow datetime format in swh.core.api.serializers
        
        it should not be used anymore.
    
    commit 5bbbba6197d8319668be2970876b6f6e29b0b248
    Author: David Douard <david.douard@sdfa3.org>
    Date:   Tue Dec 8 11:45:52 2020 +0100
    
        Drop support for legacy msgpack encodings in msgpack_loads
        
        we should be free of them by now. The journal has been recreated from
        scratch since then.

    See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/176/ for more details.

  • Author Maintainer

    Merge request was merged

  • closed

  • Please register or sign in to reply
    Loading