There is an incompatibility between latest django-stubs release (1.10.0)
and current release of djangorestframework-stubs.

So temporarily pin django-stubs to < 1.10.0 until the issue is fixed.

This introduces a checkbox to allow users to filter their own requests. It's turned on
by default. The checkbox is not shown when connected anonymously.

Either browsing anonymously or unchecking the box (when connected) allows to browse all
requests.

This also unifies the rendering with the save code now view:
- same datatable layout
- the spinner logo during computation

Related to T4011

Maintain selected tab in add-forge-now create view.
Add URL hash for the help tab.
Improve cypress tests for the tab change.

Related to T4050

Related to T4087

This will allow to reuse that part inside the add-forge-now form as well.

Related to T4011

This makes sure we use the right keycloak login link when deployed on staging and
production webapps. This does not change anything for docker and dev makefile targets.

Related to T4075

Use dedicated functions in archive module to get an origin visit by id
or by date.

Only get all visits as a fallback when one needs to get an origin visit
by snapshot.

Related to T4075

Implementation wise, this extracts and reuses an already defined function to compute
such date.

Related to T4074

Add a new administration view to manage the mailmaps in the
archive.

The view allows to add new mailmaps or update existing ones.

It requires a special user permission "swh.web.admin.mailmap"
to be used.

Only mailmaps created by users with that permission will be
displayed in that view.

JS mapping to get the right request status name
Changes in three views and cypress tests

Prior to this, the name was wrong which prevented the actual username consent from being
saved.

Moved forge request details to a separate column
Minor style changes to request history items
Added separate CSS for add-forge bundle

When rejecting a Save Code Now request, the submitted origin URL was
automatically added to the unauthorized URLs list. But this was
prolematic as a valid URL prefix could be added in that list and
thus a valid request whose origin URL has that prefix would be
automatically rejected.

So remove the automatic adding of origin URL in unauthorized list
when rejecting a request.

Also return 404 in the reject endpoint when the request does not
exist.

They are user errors, there is nothing we can do about it
and they add clutter to Sentry.

New CSS class is added to use with mandatory form fields
Added this style in create and update views of add-forge-now

When creating an add forge request and the user check the box, it's now stored in the
backend while it was ignored prior to this diff.

Related to T4057

Due to test modules being copied in subdirectories of the
build directory by setuptools, it makes pytest fail by raising
ImportPathMismatchError exceptions when invoked from root
directory of the module.

So ignore the build folder to discover tests.

Related to T4057

This fixes an inconsistency when accessing the add-forge-now moderation view as admin
without any moderation permission.

This now consistently let access to moderation to any person who is either staff or with
an add-forge-now moderator role.

This fixes errors when using django 3.2 and thus the packaging
on debian unstable

URLs targeting a django view must have a trailing slash as
django builtin feature APPEND_SLASH is activated by default.

If an URL definition does not have a trailing slash, this
will  result in a 404 error as django will automatically add
a trailing slash if a user forgot to add it and thus the URL
resolving will fail.

This will avoid having to flip it on by default all around.

Related to T4040

This is:
- plainly displaying the text message when a conflict occur.
- parse the json response otherwise when an input failure occurs.
- if the json response parsing fails too, the raw json is displayed as fallback

Related to T4052

My bad, a couple of years ago I deactivated box shadows used by
bootstrap to emphasize selected form elements.

Related to T4060

Related to T4040

Jayesh authored 3 years ago and Antoine R. Dumont committed 3 years ago

To be used by moderators to update the status of a request
Shows details about a request and its history
Cypress tests

Related to T3992
Related to T4003
Related to T4001

This also prevents the server code from being served when the feature flag is off.

Related to T4040

In a future commit, it will be possible to browse from that view to the detailed request
dashboard.

This also reworks the left menu to allow access to staff or people with the add forge
now moderator permission.

Related to T3991

This will allow easier adaptations when adding new views with different permissions.

Jayesh authored 3 years ago and Antoine R. Dumont committed 3 years ago

Added a form to submit an "add forge now" request.
Left menus changed to include "add forge now" page.
Possbility to browse existing requests is added
in a seperate tab in the same view.
Cypress tests

Related to T3998
Related to T3989
Related to T4012
Related to T3988

Antoine Lambert authored 3 years ago and Antoine R. Dumont committed 3 years ago

Merging datatables special processing in /api/1/add-forge/request/list
endpoint implementation was quite disturbing.

So better using a dedicated endpoint for that in a similar manner as
with save code now requests listing.

The endpoint to use with datatables is now the following one:
/add-forge/request/list/datatables.

Related to T3989
Related to T3991

Antoine Lambert authored 3 years ago and Antoine R. Dumont committed 3 years ago

datatables is the javascript library we use on the frontend side to
display interactive tables.

As we use server-side processing, table data must be provided in a
paginated way by an HTTP endpoint.

Response format expected by datatables is different from the one
returned by the Web API endpoint listing add-forge requests.

So adapt the response format of that endpoint when we know the
input request has been sent by datatables.

Related to T3989
Related to T3991

Antoine Lambert authored 3 years ago and Antoine R. Dumont committed 3 years ago

Related to T4030