Skip to content

Factorize the firewall properties

Vincent Sellier requested to merge generated-differential-D4482-source into generated-differential-D4482-target

The ip address is needed for the dns configuration and the icinga tests, so the properties declarations needed to be refactored to avoid duplicates

Related to T2755

Test Plan

octocatlog-diff for pergamon :

diff origin/production/pergamon.softwareheritage.org current/pergamon.softwareheritage.org
*******************************************
  Concat::Fragment[icinga2::object::Host::glyptotek.internal.softwareheritage.org] =>
   parameters =>
     content =>
      @@ -1,4 +1,5 @@
      _
       object Host "glyptotek.internal.softwareheritage.org" {
      +  address = "192.168.100.128"
         display_name = "glyptotek.internal.softwareheritage.org"
         check_command = "hostalive"
*******************************************
  Concat::Fragment[icinga2::object::Host::pushkin.internal.softwareheritage.org] =>
   parameters =>
     content =>
      @@ -1,4 +1,5 @@
      _
       object Host "pushkin.internal.softwareheritage.org" {
      +  address = "192.168.100.129"
         display_name = "pushkin.internal.softwareheritage.org"
         check_command = "hostalive"
*******************************************
  Concat_fragment[icinga2::object::Host::glyptotek.internal.softwareheritage.org] =>
   parameters =>
     content =>
      @@ -1,4 +1,5 @@
      _
       object Host "glyptotek.internal.softwareheritage.org" {
      +  address = "192.168.100.128"
         display_name = "glyptotek.internal.softwareheritage.org"
         check_command = "hostalive"
*******************************************
  Concat_fragment[icinga2::object::Host::pushkin.internal.softwareheritage.org] =>
   parameters =>
     content =>
      @@ -1,4 +1,5 @@
      _
       object Host "pushkin.internal.softwareheritage.org" {
      +  address = "192.168.100.129"
         display_name = "pushkin.internal.softwareheritage.org"
         check_command = "hostalive"
*******************************************
  Icinga2::Object::Host[glyptotek.internal.softwareheritage.org] =>
   parameters =>
     address =>
      + 192.168.100.128
*******************************************
  Icinga2::Object::Host[pushkin.internal.softwareheritage.org] =>
   parameters =>
     address =>
      + 192.168.100.129
*******************************************
  Icinga2::Object[icinga2::object::Host::glyptotek.internal.softwareheritage.org] =>
   parameters =>
     attrs =>
       address =>
        + 192.168.100.128
*******************************************
  Icinga2::Object[icinga2::object::Host::pushkin.internal.softwareheritage.org] =>
   parameters =>
     attrs =>
       address =>
        + 192.168.100.129
*******************************************
*** End octocatalog-diff on pergamon.softwareheritage.org

Migrated from D4482 (view on Phabricator)

Merge request reports