Skip to content
Snippets Groups Projects

jobs/tools: Do not inline token in script setting gitlab webhooks

Pass it as a hidden parameter instead as jenkins now requires to manually validate each groovy script for security concerns.

As a script is identified by the hash of its content, proceeding like this avoid to revalidate the webhooks setting script each time the token is rotated.

These changes have been tested locally with a local jenkins and our staging gitlab.

Merge request reports

Pipeline #4233 passed

Pipeline passed for 49421e8d on anlambert:webhooks-script-no-token-inlining

Merged by Antoine LambertAntoine Lambert 1 year ago (Sep 12, 2023 2:40pm UTC)

Loading

Pipeline #4243 failed

Pipeline failed for 49421e8d on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading