indexer: Fix deployment and name consistently the variable

swh/templates/indexers/configmap.yaml

@@ -72,7 +72,7 @@ data:
       sasl.mechanism: SCRAM-SHA-512
       security.protocol: SASL_SSL
       sasl.username: {{ $journalUser }}
-      sasl.password: ${JOURNAL_PASSWORD}
+      sasl.password: ${BROKER_USER_PASSWORD}
       {{ end -}}
 
     {{- if $deployment_config.extraConfig -}}

swh/templates/indexers/deployment.yaml

@@ -37,12 +37,12 @@ spec:
           image: debian:bullseye
           imagePullPolicy: Always
           env:
-          - name: JOURNAL_PASSWORD
+          - name: BROKER_USER_PASSWORD
             valueFrom:
               secretKeyRef:
-                name: common-secrets
-                key: journal-password
-                optional: true
+                name: {{ $.Values.indexers.journalBrokers.secretName }}
+                key: BROKER_USER_PASSWORD
+                optional: false
           command:
             - /entrypoint.sh
           volumeMounts: