Stop relying on origin ids unless necessary.

This completely stops using origin ids, except when an endpoint that depends on origin ids is used.

Related: swh-storage!907 (closed)

Test Plan

lang=bash
# Test with origin ids
pytest --hypothesis-profile=swh-web-fast swh/web/

# Disable origin ids
cd ../swh-storage/
arc patch swh/devel/swh-storage!907
cd ../swh-web/

# Test without origin ids (and disable tests that require origin ids)
SWH_STORAGE_IN_MEMORY_ENABLE_ORIGIN_IDS=false pytest --hypothesis-profile=swh-web-fast swh/web/ -m "not origin_id"

---

Migrated from D1691 (view on Phabricator)

Build is green See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/581/ for more details.

sed "s/ENABLE_ORIGIN_IDS = True/ENABLE_ORIGIN_IDS = False/" swh/storage/in_memory.py

why don't you make it a configuration option?

use a config var instead of sed

Build is green See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/585/ for more details.

mentioned in issue swh-storage#1816 (closed)

Looks good to me. FYI, pytest is printing the following warning:

PytestUnknownMarkWarning: Unknown pytest.mark.origin_id - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/latest/mark.html

The new marker needs to be explicitely declared in the pytest.ini file to remove the warning:

markers =
  origin_id: execute tests using an origin id (deselect with '-m "not origin_id"')

Merge request was accepted

approved this merge request

• rebase
• reformat
• hide pytest warning

Build is green See https://jenkins.softwareheritage.org/job/DWAPPS/job/tox/587/ for more details.

Merge request was merged

closed