Display visit status information in the save request information
Closed
requested to merge generated-differential-D5570-source into generated-differential-D5570-target
As demonstrated in the following snapshots, just placed prior to arguments [1] [2]. So this is read soon enough by users who wants more details.
Another dedicated commit also drops the redundant Task prefix in row title in save
code now detail view (included in the diff for simplicity and avoiding future gazillions
of rebases)
This is populated from now on. There is no backtracking existing visit_status into the db for prior save code now request.
-
[1] full
-
[2] not_found
Depends on !541 (closed) Related to #3266 (closed)
Test Plan
tox & frontend tests still happy as well
Migrated from D5570 (view on Phabricator)
Merge request reports
Activity
Build is green
Patch application report for D5570 (id=19901)
Could not rebase; Attempt merge onto 015ddb89...
Merge made by the 'recursive' strategy. assets/src/bundles/save/index.js | 28 +++++++++++-------- cypress/integration/origin-save.spec.js | 17 ++++++++---- requirements-test.txt | 1 + .../0009_saveoriginrequest_visit_status.py | 32 ++++++++++++++++++++++ swh/web/common/models.py | 18 ++++++++++++ swh/web/common/origin_save.py | 12 ++++++-- swh/web/tests/common/test_origin_save.py | 7 +++++ swh/web/tests/test_migrations.py | 23 ++++++++++++++++ 8 files changed, 119 insertions(+), 19 deletions(-) create mode 100644 swh/web/common/migrations/0009_saveoriginrequest_visit_status.py create mode 100644 swh/web/tests/test_migrations.pyChanges applied before test
commit 1477ad7b695f4083159f8e7618f3a5267dc1f024 Merge: 015ddb89 29bb9a4f Author: Jenkins user <jenkins@localhost> Date: Wed Apr 21 13:27:39 2021 +0000 Merge branch 'diff-target' into HEAD commit 29bb9a4f0716958db8914c9189c4b06a7e187962 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 15:03:02 2021 +0200 Drop redundant `Task` prefix in row title in save code now detail view Related to #3266 commit bedbd2f2d0ea935cf5dc4c2c7b210a483015bf6c Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 14:58:08 2021 +0200 Display visit status information in the save request information As demonstrated in the following snapshot, just placed prior to arguments [1]. So this is read soon enough by users who wants more details. - [1] https://forge.softwareheritage.org/F4420335 Related to #3266 commit 1e7e00b3cab0749ed72d7a6800594beb1b6f4ee5 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 13:59:19 2021 +0200 Populate the visit status value in save code now request Related to #3266 commit fb1f5bbd85137f0754435c10784d03aa41efd20e Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Apr 19 18:26:33 2021 +0200 Add visit_status to SaveOriginRequest model Related to #3266See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/707/ for more details.
-
Build is green
Patch application report for D5570 (id=19909)
Could not rebase; Attempt merge onto 015ddb89...
Merge made by the 'recursive' strategy. assets/src/bundles/save/index.js | 93 ++++++++-------------- cypress/integration/origin-save.spec.js | 17 ++-- requirements-test.txt | 1 + swh/web/api/views/origin_save.py | 2 + .../0009_saveoriginrequest_visit_status.py | 32 ++++++++ swh/web/common/models.py | 18 +++++ swh/web/common/origin_save.py | 12 ++- swh/web/tests/common/test_origin_save.py | 7 ++ swh/web/tests/test_migrations.py | 23 ++++++ 9 files changed, 137 insertions(+), 68 deletions(-) create mode 100644 swh/web/common/migrations/0009_saveoriginrequest_visit_status.py create mode 100644 swh/web/tests/test_migrations.pyChanges applied before test
commit 48b54f62a53a4c0a935978af69b6cb95058f99d9 Merge: 015ddb89 fcd74383 Author: Jenkins user <jenkins@localhost> Date: Wed Apr 21 15:38:19 2021 +0000 Merge branch 'diff-target' into HEAD commit fcd74383f75915d4233b754f30f9e01ea972e407 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 15:03:02 2021 +0200 Drop redundant `Task` prefix in row title in save code now detail view Related to #3266 commit 6aeaad45cce4cb02b98b0d988955a7b3a5f4cad2 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 14:58:08 2021 +0200 Display visit status information in the save request information As demonstrated in the following snapshot, just placed prior to arguments [1]. So this is read soon enough by users who wants more details. - [1] https://forge.softwareheritage.org/F4420335 Related to #3266 commit 80f35d1ef288a8f8dad8edcf61e2bdebe839c504 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 13:59:19 2021 +0200 Populate the visit status value in save code now request Related to #3266 commit fb1f5bbd85137f0754435c10784d03aa41efd20e Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Apr 19 18:26:33 2021 +0200 Add visit_status to SaveOriginRequest model Related to #3266See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/709/ for more details.
Some references in the commit message have been migrated:
- T3266 is now #3266 (closed)
Some references in the commit message have been migrated:
- T3266 is now #3266 (closed)
-
Build has FAILED
Patch application report for D5570 (id=19914)
Could not rebase; Attempt merge onto 015ddb89...
Updating 015ddb89..85253bc8 Fast-forward assets/src/bundles/save/index.js | 93 ++++++++-------------- cypress/integration/origin-save.spec.js | 17 ++-- requirements-test.txt | 1 + swh/web/api/views/origin_save.py | 6 ++ .../0009_saveoriginrequest_visit_status.py | 32 ++++++++ swh/web/common/models.py | 18 +++++ swh/web/common/origin_save.py | 12 ++- swh/web/tests/api/views/test_origin_save.py | 11 ++- swh/web/tests/common/test_origin_save.py | 7 ++ swh/web/tests/test_migrations.py | 23 ++++++ 10 files changed, 150 insertions(+), 70 deletions(-) create mode 100644 swh/web/common/migrations/0009_saveoriginrequest_visit_status.py create mode 100644 swh/web/tests/test_migrations.pyChanges applied before test
commit 85253bc88f6ea7d625e041b3dfaf49c5096f353c Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 15:03:02 2021 +0200 Drop redundant `Task` prefix in row title in save code now detail view Related to #3266 commit e6cce7a595b8dbd3b8c089d3e7e018eae8cb6b65 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 14:58:08 2021 +0200 Display visit status information in the save request information As demonstrated in the following snapshot, just placed prior to arguments [1]. So this is read soon enough by users who wants more details. - [1] https://forge.softwareheritage.org/F4420335 Related to #3266 commit 83f93270101e2de20bf65bf829c421230b88e3fc Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 13:59:19 2021 +0200 Populate the visit status value in save code now request Related to #3266 commit 1042f73c181d722e681a562088afcdcc2ee0af69 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Apr 19 18:26:33 2021 +0200 Add visit_status to SaveOriginRequest model Related to #3266Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/714/ See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/714/console
-
Build is green
Patch application report for D5570 (id=19914)
Could not rebase; Attempt merge onto 015ddb89...
Updating 015ddb89..85253bc8 Fast-forward assets/src/bundles/save/index.js | 93 ++++++++-------------- cypress/integration/origin-save.spec.js | 17 ++-- requirements-test.txt | 1 + swh/web/api/views/origin_save.py | 6 ++ .../0009_saveoriginrequest_visit_status.py | 32 ++++++++ swh/web/common/models.py | 18 +++++ swh/web/common/origin_save.py | 12 ++- swh/web/tests/api/views/test_origin_save.py | 11 ++- swh/web/tests/common/test_origin_save.py | 7 ++ swh/web/tests/test_migrations.py | 23 ++++++ 10 files changed, 150 insertions(+), 70 deletions(-) create mode 100644 swh/web/common/migrations/0009_saveoriginrequest_visit_status.py create mode 100644 swh/web/tests/test_migrations.pyChanges applied before test
commit 85253bc88f6ea7d625e041b3dfaf49c5096f353c Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 15:03:02 2021 +0200 Drop redundant `Task` prefix in row title in save code now detail view Related to #3266 commit e6cce7a595b8dbd3b8c089d3e7e018eae8cb6b65 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 14:58:08 2021 +0200 Display visit status information in the save request information As demonstrated in the following snapshot, just placed prior to arguments [1]. So this is read soon enough by users who wants more details. - [1] https://forge.softwareheritage.org/F4420335 Related to #3266 commit 83f93270101e2de20bf65bf829c421230b88e3fc Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Wed Apr 21 13:59:19 2021 +0200 Populate the visit status value in save code now request Related to #3266 commit 1042f73c181d722e681a562088afcdcc2ee0af69 Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org> Date: Mon Apr 19 18:26:33 2021 +0200 Add visit_status to SaveOriginRequest model Related to #3266See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/715/ for more details.
Please register or sign in to reply