Skip to content

assets/revision/diff-utils: Fix text selection in revision view

Antoine Lambert requested to merge generated-differential-D4491-source into generated-differential-D4491-target

A javascript click handler was modifying the view URL fragment without any checks.

Modifying the view URL fragment has the side effect of scrolling the view and prevents proper text selection.

Surprisingly, that bug only occured on Firefox.

Test Plan

I tried to write a cypress test to reproduce the issue but simulating text selection with the mouse does not seem to be possible with cypress.

Migrated from D4491 (view on Phabricator)

Merge request reports