- Feb 17, 2021
-
-
Antoine R. Dumont authored
Related to T1410
-
- Feb 16, 2021
-
-
Antoine Lambert authored
Conditionally allow to use swh-search backend in search_origin_metadata function based on swh-web configuration: - "search" configuration dict must be present and not empty - "metadata_search_backend" field must be set to "swh-search" Closes T3047
-
Antoine Lambert authored
This prevents polluting pytest output with those tracebacks.
-
Antoine Lambert authored
Traceback of an exception caught in a django view error handler was included in error responses but not logged to stderr. While the exception traceback is clearly readable in browse error pages, it is not in Web API responses because of the JSON format. So ensure the traceback is also logged to stderr for better debugging.
-
- Feb 05, 2021
-
-
Antoine Lambert authored
That was missed in rDWAPPSc53756359a43340d08d96a90c05a5b49dec52dbb and prevented the origin browse link to be displayed in "Save code now" admin interface.
- Feb 03, 2021
-
- Feb 02, 2021
-
-
Antoine Lambert authored
It will enable to catch possible side effects when swh-loader-git codebase is updated.
-
- Jan 26, 2021
-
-
Antoine Lambert authored
Fix new errors appeared since mypy 0.800 release in a Python file used by the cypress tests to check code highlighting.
-
- Jan 21, 2021
-
-
Antoine Lambert authored
SWHID links related to reachable revision, directory or content from a browsed release were missing in the view. This fixes the vault cooking task creation for the target directory through the use of the "Download" link in the release view. Closes T2982
-
Antoine Lambert authored
Django application label must be a valid Python identifiers and thus must not contain dot characters. Having invalid identifiers will make database data importing from JSON fails otherwise. Related django issue: https://code.djangoproject.com/ticket/32285 Related to T2945
- Jan 12, 2021
-
-
Antoine Lambert authored
hypothesis 6.0 release turned the warning about using function scope pytest fixtures into an error which makes a lot of tests now failing. So add the new HealthCheck.function_scoped_fixture value into the suppress_health_check list of hypothesis profiles settings.
-
- Jan 08, 2021
-
-
Antoine Lambert authored
Ensure the responses that are streamed by the graph service are also streamed in the Web API endpoint proxying it. Closes T2900
-
- Jan 07, 2021
-
-
vlorentz authored
In make_api_response, empty lists were not JSONized because they were mistakenly detected as a None, which caused these empty lists to be passed to urlize_links_and_mails, which expects strings. It caused a TypeError when calling re.sub() on it, which was catched so it still returned a result (and a correct one, since empty lists don't need substitution). This commit removes the catch workaround and always passes the right type.
-
- Jan 06, 2021
-
-
Antoine Lambert authored
Improve the overall performance when one wants to display a specific page of the save code now requests list by: - Applying possibly costly operations (like finding the visit date) only on the save requests to display (the whole list was considered previously) - Implementing search feature using Django model instead of pure Python Also add missing tests.
-
vlorentz authored
-
Antoine Lambert authored
-
Antoine Lambert authored
-
- Jan 05, 2021
-
-
Antoine Lambert authored
Previously when an access token has expired, the OIDC session was attempted to be silently refreshed through the use of the OIDCSessionRefreshMiddleware class. But silent refresh should only be performed with the OIDC Implicit flow as no refresh token gets issued in that case. swh-web uses OIDC Authorization Code flow to login users so that commit implements access token renewal directly in the django auth backend through the use of a refresh token. Currently, refresh token have a living period of 30 minutes, meaning a user can have its authenticated session in idle state during that period. If he visits a new web page during that idle period, its authenticated session will then be renewed for another 30 minutes. Also rename OIDCSessionRefreshMiddleware to OIDCSessionExpiredMiddleware. The middleware will now simply redirects to the logout page if it detects the OIDC session has expired.
-
- Dec 30, 2020
-
-
vlorentz authored
It's not an actual error, it doesn't deserve to be logged.
-
- Dec 14, 2020
-
-
Antoine Lambert authored
Some external resolver or software might mangle the "://" character sequence into ":/" for the origin qualifier value of a SWHID. This can lead to 404 errors when trying to resolve such a SWHID as the origin will be found missing due to the typo. So handle that special case to avoid such errors. Related to T2797 Closes T2878
- Dec 11, 2020
-
-
Antoine Lambert authored
When browsing a content through the revision view, the click event handlers for highlighting content lines or diff lines in the Changes tab were in conflict leading to weird GUI behavior. So ensure each click handler is executed only when needed. Also modifying URL fragment when resetting diff highlighting triggers the hashchange handler for code highlighting so avoid processing the fragment if it does not match line numbers regexp. Finally, prevent unwanted document scrolling when modifying URL fragment after the cancellation of diff highlighting.
-
Antoine Lambert authored
Closes T2880
-
- Dec 10, 2020
-
-
Antoine Lambert authored
Instead of using the OIDC Direct Grant flow to generate bearer tokens for Web API authentication, use the more secured Authorization Code flow (as in webapp login) to avoid proxying SSO credentials from django backend to Keycloak server. As a consequence, previously stored encrypted tokens in webapp database has to be removed as the encryption scheme has changed. Hopefully, there is currently only a couple in production database generated by swh staff members so the impact will be quite limited.
-
- Dec 09, 2020
-
- Dec 08, 2020
-
- Dec 04, 2020
-
-
Antoine Lambert authored
It enables to consolidate counter graphs displayed in main archive page. Closes T2619
-
Antoine Lambert authored
Rework the content of the popup than can be shown when clicking on the "Show metadata" button by only displaying raw metadata associated to a swh object. As only revision objects can have raw metadata associated, hide the toggle button in views dedicated to browse other object types. The button will also be hidden if revision metdata are empty. Closes T2848
-
- Dec 03, 2020
-
-
Antoine Lambert authored
When trying to browse a content or a directory in another object context (snapshot, revision, directory), if the targetted object can not be found (for instance after changing the current branch in a snapshot) display a 404 error while keeping display of context related UI to ease the navigation. Also improve the displayed error message when a directory entry with a given path can not be found from a root directory. Closes T2353
-
Antoine Lambert authored
-
Antoine Lambert authored
-
- Dec 02, 2020
-
-
Antoine Lambert authored
-
Antoine Lambert authored
The postcss configuration is already defined in webpack configuration so it can be removed from the package.json file. It was needed at some time due to a postcss configuration bug but this is not the case anymore. It also enables to remove disturbing stylelint warnings when compiling with webpack.
-
Antoine Lambert authored
Add a small status widget in the top bar of the main HTML layout linking to https://status.softwareheritage.org/ and asynchronously getting Software Heritage status data from the status.io API. Closes T2402
-
- Nov 25, 2020
-
-
Antoine Lambert authored
Due to a recent factoring related to api_* decorators, the effect of the never_cache django decorator was not applied anymore. So add a never_cache parameter to the api_route decorator ensuring cache-control reponse header will be set when required. Also add missing tests checking cache-control header in api responses. Closes T2810
-
- Nov 24, 2020
-
-
vlorentz authored
-