Skip to content
Snippets Groups Projects
Commit 25af062c authored by Kalpit Kothari's avatar Kalpit Kothari
Browse files

Fix xss vulnerability in origin save

Summary:
Related T1690
Added client side xss filter

> Save code now is vulnerable to XSS attack.
>
> Steps to reproduce-
>
>     Remove the validation from client side (with dev tools)
>     Enter this url in origin url
>
> https://github.com/%3Cscript%3Ealert(document.domain);%3C/script%3E
>
> We should add more validations at the server side to prevent such urls from entering into the database.

For server side validations, I was thinking of preventing regex /.*(%3C).*(%3E)/ and /.*(javascript:).*/  There may be a few more cases we need to take care of.

Or should we check if the url returns 200 or not before entering it to the table.

Reviewers: #reviewers, anlambert

Reviewed By: #reviewers, anlambert

Subscribers: anlambert, vlorentz

Differential Revision: https://forge.softwareheritage.org/D1433
parent 65501f32
Branches poll-thread
No related tags found
1 merge request!99Fix xss vulnerability in origin save
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment