Skip to content
Snippets Groups Projects

Instanciate the SMTP class only when needed

Closed Instanciate the SMTP class only when needed
generated-differential-D8205-source into generated-differential-D8205-target
Closed David Douard requested to merge generated-differential-D8205-source into generated-differential-D8205-target
  1. Sep 14, 2022
    • David Douard's avatar
      Instanciate the SMTP class only when needed · cab17e72
      David Douard authored 
      instead of creating it in the VaultBackend constructor: when configured
(with host and port), SMTP.connect() is immediately called, which makes
it mandatory to have the smtp server up and running to be able to create
the VaultBackend object (which makes it hard to run properly in an elastic
environment like docker or k8s).

This also removes the fallback to hardcoded 'localhost:25' smtp server;
if the smtp server is not configured or not reachable, the call to
_smtp_send() will fail logging the failure (both in logging and sentry).
      cab17e72