Skip to content

Move sharable fixtures out of conftest into a dedicated pytest plugin

Antoine R. Dumont requested to merge generated-differential-D3452-source into generated-differential-D3452-target

This will allow loaders to reuse those dedicated fixtures within their code base without having to import the swh.storage.tests.conftest module.

(Note: I find the diff displayed a tad weirdly as i only move code from conftest to a new pytest_plugin..., did not remove anything...)

Related to T2484

Test Plan

tox

And ensure client wise (locally), it's indeed reusable as in [1]:

  • adapting locally swh.loader.core requirement-test.txt to swh.storage[testing]

  • dropping spurrious swh.storage.tests.conftests.* import

  • tox amended with storage .tox/bin/pip install -e ../swh-storage

  • all tests are green

  • [1] See D3453

Migrated from D3452 (view on Phabricator)

Merge request reports