Skip to content

origin_visit_update: Simplify api endpoint to pass only the visit

Antoine R. Dumont requested to merge generated-differential-D2822-source into generated-differential-D2822-target

And not both the origin and the visit. The visit holds already the necessary information we want about the origin.

Before (after adding the type effectively used)

       def origin_visit_update(
          self, origin: Origin, visit: OriginVisit,
          status: Optional[str] = None,
          metadata: Optional[Dict] = None,
          snapshot: Optional[bytes] = None):

After:

    def origin_visit_update(
            self,
            visit: OriginVisit,
            status: Optional[str] = None,
            metadata: Optional[Dict] = None,
            snapshot: Optional[bytes] = None) -> None:

Depends on !914 (closed)

Test Plan

tox

Migrated from D2822 (view on Phabricator)

Merge request reports