origin_visit_upsert: Use OriginVisit objects as input (!913) · Merge requests · Platform / Development / swh-storage · GitLab

Snippets Groups Projects

Closed Antoine R. Dumont requested to merge generated-differential-D2813-source into generated-differential-D2813-target 5 years ago

1 unresolved thread

This aligns with other _add endpoints [1]

Impacts:

D2826: swh-journal (replayer)

Related to swh-journal!132 (closed)

[1] except for origin_visit_add which is next (D2820)

Test Plan

tox

Migrated from D2813 (view on Phabricator)

Activity

Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build is green See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1044/ for more details.
vlorentz @vlorentz started a thread on the diff 5 years ago

swh/storage/db.py

         })
         cur.execute(query, (*values, *where_values))
     def origin_visit_upsert(self, origin, visit, date, type, status,
                             metadata, snapshot, cur=None):
     def origin_visit_upsert(self, origin_visit: OriginVisit, cur=None) -> None:

vlorentz @vlorentz · 5 years ago

Maintainer

Merge request was returned for changes

Phabricator Migration user @phabricator-migration commented on commit 0456cce5 5 years ago

Owner
Some references in the commit message have been migrated:

D2812#67298 is now swh-journal!132 (closed)

Antoine R. Dumont @ardumont · 5 years ago

Author Maintainer

Adapt according to review

Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1055/ See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1055/console

Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build was aborted

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1056/ See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tox/1056/console

Software Heritage Continuous Integration for public repositories @swh-public-ci · 5 years ago

Build is green See https://jenkins.softwareheritage.org/job/DSTO/job/tox/1059/ for more details.

vlorentz mentioned in merge request swh-journal!248 (closed) 5 years ago

mentioned in merge request swh-journal!248 (closed)

vlorentz @vlorentz · 5 years ago

Maintainer

vlorentz @vlorentz · 5 years ago

Maintainer

Merge request was accepted

vlorentz approved this merge request 5 years ago

approved this merge request

Antoine R. Dumont @ardumont · 5 years ago

Author Maintainer

Merge request was merged

Antoine R. Dumont closed 5 years ago

closed

Phabricator Migration user mentioned in commit 5 years ago

mentioned in commit swh-journal@d3d5b797

Please register or sign in to reply