Skip to content

Refactor the JournalWriter class to normalize its methods

David Douard requested to merge generated-differential-D3138-source into generated-differential-D3138-target

make all the add_xxx methods take an Iterable as argument. Also extract the conditional execution of the underlying journal method calls in a dedicated methof to prevent repeating the if self.journal all over the place.

Ensure all the storage code that uses this JournalWriter class are updated accordingly.

Also in this diff:

  • Improve a bit the exception message of JournalWriter.content_update
  • Add missing return annotations on JournalWriter methods

Depends on !395 (closed).

Migrated from D3138 (view on Phabricator)

Merge request reports