Open origin_visit api in storage + Update occurrence_add api

A few comments inline

Merge request was returned for changes

sql/upgrades/075: 074→075 - Add status info to origin_visit
Add origin_visit api entry points to create/update origin_visit

Add origin_visit api entry points to create/update origin_visit

Add origin_visit api entry points to create/update origin_visit

mentioned in commit f14c4bea

Update occurrence_add api entry point to deal with origin_visit
Fix origin_visit time policy in occurrence_add api
Cleanup obsolete reference to date in occurrence_add entry

For consistency with how other object additions are handled, I think we should add a visit column to the occurrence_history temporary table, and use that to populate the "visit" object, rather than pass a new argument to occurrence_add.

Case in point, one of the two new arguments is not being used currently (the origin_id is pulled from the temporary table).

We can revisit this later when we'll have nailed down the so-called snapshot objects, but for now I think consistency trumps any future goals.

Merge request was returned for changes

@olasd Right! Thanks.

Update occurrence_add api entry point to properly deal with origin_visit

Update occurrence_add api entry point to properly deal with origin_visit

I think both database upgrades should be merged as 075 is currently breaking stuff that 076 fixes. Apart from that, this looks good.

Thanks!

Merge request was accepted

approved this merge request

Update occurrence_add api entry point to properly deal with origin_visit

I think both database upgrades should be merged as 075 is currently breaking stuff that 076 fixes.

Yes, done.

Merged in rDSTOf14c4bea

Merge request was abandoned

closed

Open origin_visit api in storage + Update occurrence_add api

Merge request reports

Activity