Skip to content
Snippets Groups Projects

Add StorageInterface.skipped_content_find()

To create recovery bundle, swh-alter needs to be able to retrieve full SkippedContent objects from the storage.

The new method skipped_content_find() allows to retrieve all SkippedContent objects matching a given set of hashes. Usually, this should only be one, but multiple objects might be returned in case of hash collisions.

While implementing this, #4693 was identified which prevent testing the implementation with the PostgreSQL storage in the case a SkippedContent references a known origin.

Ref: swh-alter#6 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Dandrimont approved this merge request

    approved this merge request

  • Looks fine to me. You've got a spurious debug print left over in the cassandra bits that you should fix up when rebasing!

  • Good catch! Thanks for the quick review :)

  • added 1 commit

    • abbe06db - Add StorageInterface.skipped_content_find()

    Compare with previous version

  • Jenkins job DSTO/gitlab-builds #271 failed .
    See Console Output and Coverage Report for more details.

  • @jenkins please retry build

  • Jenkins job DSTO/gitlab-builds #272 failed .
    See Console Output and Coverage Report for more details.

  • @jenkins please retry build

  • Jenkins job DSTO/gitlab-builds #273 succeeded .
    See Console Output and Coverage Report for more details.

  • vlorentz
  • vlorentz
  • vlorentz
  • nice!

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading