swh.scheduler.celery_backend.config: Permit task bytes serialization
Closed
requested to merge generated-differential-D300-source into generated-differential-D300-target
1 unresolved thread
Migrated from D300 (view on Phabricator)
Merge request reports
Activity
19 19 20 20 from swh.core.config import load_named_config 21 21 from swh.core.logger import JournalHandler 22 from kombu.serialization import register 23 from swh.core.serializers import swh_json_dumps, swh_json_loads mentioned in commit 367ab150
Discussion took place in irc:
13:17:49 +olasd | no, that's a very bad idea 13:18:03 +olasd | just set the serializer to msgpack or pickle 13:18:51 +ardumont | why is that a bad idea? 13:19:25 +olasd | we should stop piling hacks on top of hacks and use built-in things that work 13:19:42 +ardumont | i don't get why that is a hack 13:25:09 +olasd | it adds a non-default serialization format that nobody else in the world supports, when there are perfectly fine alternatives that work and are supported upstream 13:25:38 +seirl | ardumont: trying to shove in binary data in json is pretty much always a bad idea 13:26:04 +ardumont | well, yeah but i'm reusing stuff we use anyway 13:26:31 +ardumont | ok, as we are supposed to be away from pickle, i'm taking msgpack then 13:26:56 +seirl | (Y) 13:28:23 +olasd | yes please
Please register or sign in to reply