cli.add_forge_now: Allow queue name prefix override

This will allow to schedule add-forge-now requests to different queues. For example [1] will send git tasks to the add_forge_now_slow:swh.loader.git... queue.

That queue being configured to be consumed by worker with a different, e.g. a slow, workload than the standard one.

[1]

swh ... add-forge-now ... \
  --preset $ENVIRONMENT \
  schedule-first-visits \
    --type-name git \
    --prefix-queue add_forge_now_slow

Refs. swh/infra/ci-cd/swh-charts!59 (merged)

changed the description

Jenkins job DSCH/gitlab-builds #47 succeeded .
See Console Output and Coverage Report for more details.

changed the description

For more proper English, this should be queue-prefix (or even more precisely queue-name-prefix), rather than prefix-queue.

There was a typo in the format string for the queue name (too much puppet?)

added 1 commit

• 61b011e1 - cli.add_forge_now: Allow prefix queue name override

Compare with previous version

the typo in the format string is still there

Jenkins job DSCH/gitlab-builds #48 succeeded .
See Console Output and Coverage Report for more details.

(also, the fact that the typo remained and the tests are green makes me think the tests are missing a check whether the final queue name is good)

added 1 commit

• 1c38463a - cli.add_forge_now: Allow queue name prefix override

Compare with previous version

Jenkins job DSCH/gitlab-builds #49 succeeded .
See Console Output and Coverage Report for more details.

resolved all threads

i like it ;)

changed this line in version 4 of the diff

I adapted from it but it raises when it does not find the string. So instead i used a try except block.

wow, I'm not sure from what weird corner of my brain the "index is negative when needle not found" thing came from, but indeed it does raise a ValueError.

When is that not true? We use call_args_list above, maybe we should do that here as well?

It's not about the current runtime, I recall related issues in the debian build (because it's using more recent version with api change or something). I can also just drop that if and see when the build fails (if it does).

changed this line in version 4 of the diff

I dropped it.

We could also use the call_args_list indeed but I did not bother... I'll double check tomorrow.

added 1 commit

• cf2ca93d - cli.add_forge_now: Allow queue name prefix override

Compare with previous version

Jenkins job DSCH/gitlab-builds #50 succeeded .
See Console Output and Coverage Report for more details.

approved this merge request