Move the `last_scheduled` ts from ListedOrigin to OriginVisitStatus
this timestamp being actually a loading-related value, it makes more sense to keep it in the OriginVisitStatus table.
Related to #2444.
Migrated from D4881 (view on Phabricator)
Merge request reports
Activity
Build is green
Patch application report for D4881 (id=17338)
Rebasing onto 5e609d52...
Current branch diff-target is up to date.Changes applied before test
commit f87d9d62fd087e373d1e86fdbbc6a7b5f6c09f24 Author: David Douard <david.douard@sdfa3.org> Date: Tue Jan 19 14:45:09 2021 +0100 Move the `last_scheduled` ts from ListedOrigin to OriginVisitStatus this timestamp being actually a loading-related value, it makes more sense to keep it in the OriginVisitStatus table. Related to #2444.See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/157/ for more details.
-
Build is green
Patch application report for D4881 (id=17339)
Rebasing onto 5e609d52...
Current branch diff-target is up to date.Changes applied before test
commit dd905f5adeca8a4ea83f05b62b45dcc354a30d42 Author: David Douard <david.douard@sdfa3.org> Date: Tue Jan 19 14:45:09 2021 +0100 Move the `last_scheduled` ts from ListedOrigin to OriginVisitStatus this timestamp being actually a loading-related value, it makes more sense to keep it in the OriginVisitStatus table. Related to #2444.See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/158/ for more details.
Nice!
I've taken the liberty of reorganizing/rewriting the SQL; I have quickly tested it on a scratch database and it seems to work.
I think we'll be able to use the same three-part query scaffolding to implement other scheduling policies, only changing the filter / sort criteria, so that feels like a big win.
-
Build is green
Patch application report for D4881 (id=17346)
Rebasing onto 5e609d52...
Current branch diff-target is up to date.Changes applied before test
commit 197dcea6448b15f39fd5406ab3b741a00de8319d Author: David Douard <david.douard@sdfa3.org> Date: Tue Jan 19 14:45:09 2021 +0100 Move the `last_scheduled` ts from ListedOrigin to OriginVisitStatus this timestamp being actually a loading-related value, it makes more sense to keep it in the OriginVisitStatus table. Related to #2444.See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/159/ for more details.
Some references in the commit message have been migrated:
- T2444 is now #2444
-
Build is green
Patch application report for D4881 (id=17352)
Rebasing onto 0a32a311...
Current branch diff-target is up to date.Changes applied before test
commit f8627a96fed6fa8d4485d4092159982dd5c6362b Author: David Douard <david.douard@sdfa3.org> Date: Tue Jan 19 14:45:09 2021 +0100 Move the `last_scheduled` ts from ListedOrigin to OriginVisitStatus this timestamp being actually a loading-related value, it makes more sense to keep it in the OriginVisitStatus table. Related to #2444.See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/163/ for more details.
