Add support for querying c-in-d + d-in-r
Merge request reports
Activity
Jenkins job DPROV/gitlab-builds #132 failed in 31 sec.
See Console Output, Blue Ocean and Coverage Report for more details.(now that swh/infra/ci-cd/swh-jenkins-dockerfiles!78 (merged) is merged; the Docker image should have the latest Rust version so that we can compile the latest version of parquet-aramid, which depends on the newly stabilized
std::iter::repeat_n
)Edited by vlorentz
Jenkins job DPROV/gitlab-builds #133 failed in 5 min 18 sec.
See Console Output, Blue Ocean and Coverage Report for more details.Jenkins job DPROV/gitlab-builds #134 succeeded in 2 min 47 sec.
See Console Output, Blue Ocean and Coverage Report for more details.Jenkins job DPROV/gitlab-builds #135 succeeded in 2 min 47 sec.
See Console Output, Blue Ocean and Coverage Report for more details.Jenkins job DPROV/gitlab-builds #137 succeeded in 6 min 11 sec.
See Console Output, Blue Ocean and Coverage Report for more details.434 schema, 435 "c_in_d", // table name, for error messages 436 "cnt", 437 "dir", 438 node_ids, 439 None, // no limit 440 ) 441 .await 442 .context("Could not query c_in_d")?; 443 tracing::trace!("Got c_in_d_stream"); 444 tracing::debug!("Scan init metrics: {:#?}", scan_init_metrics); 445 446 Ok((scan_init_metrics, scan_metrics, c_in_d_stream)) 447 } 448 449 /// Given a [`NodeId`], returns some records from the contents-in-revision table 467 let limit = 1; 468 let (scan_init_metrics, scan_metrics, d_in_r_stream) = query_x_in_y_table( 469 &self.db.d_in_r, 470 schema, 471 "d_in_r", // table name, for error messages 472 "dir", 473 "revrel", 474 node_ids, 475 Some(limit), 476 ) 477 .await 478 .context("Could not query d_in_r")?; 479 tracing::trace!("Got d_in_r_stream"); 480 tracing::debug!("Scan init metrics: {:#?}", scan_init_metrics); 481 482 // Read batches of rows, stopping after the first one the inconsistency will be fixed by !187 (merged)
mentioned in merge request !187 (merged)
lgtm (but who am I to judge? :-)
Would be nice to have a bit more comment/doc. Eg. in metrics.rs, it would be nice to have some context on how and this code is used for (without digging in queries). (Also it's not clear to me why this MR adds so much code in this metrics.rs file).
Anyway, thanks
Eg. in metrics.rs, it would be nice to have some context on how and this code is used for (without digging in queries).
I agree. I'm planning to document this once I'm done changing everything all the time.
(Also it's not clear to me why this MR adds so much code in this metrics.rs file).
so we can use the obvious operators elsewhere in the code. It's a shame Rust can't auto-generate those.