Deprecate the `args` argument to get_objstorage in favor of kwargs

This makes get_objstorage consistent with most of the other get_foo factories available in other swh modules.

We will need to do a pass to drop the few hundred args that are used currently.

Test Plan

tox tests updated

---

Migrated from D4212 (view on Phabricator)

Build is green

Patch application report for D4212 (id=14847)

Rebasing onto 6a9896d6...

First, rewinding head to replay your work on top of it...
Applying: Deprecate the `args` argument to get_objstorage in favor of kwargs

Changes applied before test

commit 4c4364c6b0593808d60d3d145710d20f280ad210
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Oct 8 21:59:20 2020 +0200

    Deprecate the `args` argument to get_objstorage in favor of kwargs
    
    This makes get_objstorage consistent with most of the other `get_foo` factories
    available in other swh modules.
    
    We will need to do a pass to drop the few hundred `args` that are used
    currently.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/15/ for more details.

Rebase

Build is green

Patch application report for D4212 (id=14848)

Rebasing onto 6a9896d6...

Current branch diff-target is up to date.

Changes applied before test

commit b78406dcecc4c442fa08ad21e615354e813d5935
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Oct 8 21:59:20 2020 +0200

    Deprecate the `args` argument to get_objstorage in favor of kwargs
    
    This makes get_objstorage consistent with most of the other `get_foo` factories
    available in other swh modules.
    
    We will need to do a pass to drop the few hundred `args` that are used
    currently.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/16/ for more details.

lgtm, a couple of suggestions inline ;)

Merge request was accepted

approved this merge request

Apply ardumont's comments

Build is green

Patch application report for D4212 (id=14855)

Rebasing onto 6a9896d6...

Current branch diff-target is up to date.

Changes applied before test

commit aa19b280840c0bd1e47d9d4741fa76bf9a4df7db
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Oct 9 12:04:38 2020 +0200

    Coalesce successful server config loading tests into a single one

commit 289f9709f5951e28f480f1ae67f2bd60ef14eb26
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Oct 9 12:03:28 2020 +0200

    Replace manual pytest.raises mangling with the match argument

commit b78406dcecc4c442fa08ad21e615354e813d5935
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Thu Oct 8 21:59:20 2020 +0200

    Deprecate the `args` argument to get_objstorage in favor of kwargs
    
    This makes get_objstorage consistent with most of the other `get_foo` factories
    available in other swh modules.
    
    We will need to do a pass to drop the few hundred `args` that are used
    currently.

See https://jenkins.softwareheritage.org/job/DOBJS/job/tests-on-diff/17/ for more details.

Merge request was merged

closed